From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, x86@kernel.org,
mhiramat@kernel.org, mbenes@suse.cz, brgerst@gmail.com,
jthierry@redhat.com
Subject: Re: [PATCH v3 26/26] objtool: Add STT_NOTYPE noinstr validation
Date: Wed, 25 Mar 2020 17:50:50 +0100 [thread overview]
Message-ID: <20200325165050.GC20696@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200325164046.p2oxemcjnj2tnxbz@treble>
On Wed, Mar 25, 2020 at 11:40:46AM -0500, Josh Poimboeuf wrote:
> On Wed, Mar 25, 2020 at 04:53:48PM +0100, Peter Zijlstra wrote:
> > On Wed, Mar 25, 2020 at 09:42:11AM -0500, Josh Poimboeuf wrote:
> > > Sure, but couldn't validate_unwind_hints() and
> > > validate_reachable_instructions() be changed to *only* run on
> > > .noinstr.text, for the vmlinux case? That might help converge the
> > > vmlinux and !vmlinux paths.
> >
> > You're thinking something like so then?
>
> Not exactly. But I don't want to keep churning this patch set. I can
> add more patches later, so don't worry about it.
>
> But I was thinking it would eventually be good to have the top-level
> check() be like
>
> sec = NULL;
> if (!validate_all)
> sec = find_section_by_name(file->elf, ".noinstr.text");
>
> ret = validate_functions(&file, sec);
> if (ret < 0)
> goto out;
> warnings += ret;
>
> ret = validate_unwind_hints(&file, sec);
> if (ret < 0)
> goto out;
> warnings += ret;
>
> if (!warnings) {
> ret = validate_reachable_instructions(&file, sec);
> if (ret < 0)
> goto out;
> warnings += ret;
> }
>
> if (!validate_all)
> goto out;
>
> ret = validate_retpoline(&file);
> ....
>
> that way the general flow is the same regardless...
Ah,... I see what you mean, there's two little wrinkles with that:
- validate_reachable_instructions() is strictly superluous, it does no
additional validation between the !vmlinux and vmlinux mode, so I'd
put that if (!validate_all) goto out, one up.
- tglx has a patch adding .entry.text to be considered as noinstr as a
whole, which has:
@@ -2636,11 +2637,16 @@ static int validate_vmlinux_functions(st
int warnings = 0;
sec = find_section_by_name(file->elf, ".noinstr.text");
- if (!sec)
- return 0;
+ if (sec) {
+ warnings += validate_section(file, sec);
+ warnings += validate_unwind_hints(file, sec);
+ }
- warnings += validate_section(file, sec);
- warnings += validate_unwind_hints(file, sec);
+ sec = find_section_by_name(file->elf, ".entry.text");
+ if (sec) {
+ warnings += validate_section(file, sec);
+ warnings += validate_unwind_hints(file, sec);
+ }
return warnings;
}
Anyway, yes, we can do this on top.
I was going to commit the first 17 patches to tip/core/objtool and
repost the remaining 13 once more. And then see how much pain I did to
Julien's patches :-)
next prev parent reply other threads:[~2020-03-25 16:50 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 15:31 [PATCH v3 00/26] objtool: vmlinux.o and noinstr validation Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 01/26] objtool: Introduce validate_return() Peter Zijlstra
2020-03-25 8:39 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 02/26] objtool: Rename func_for_each_insn() Peter Zijlstra
2020-03-25 8:43 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 03/26] objtool: Rename func_for_each_insn_all() Peter Zijlstra
2020-03-25 8:44 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 04/26] x86/kexec: Use RIP relative addressing Peter Zijlstra
2020-03-25 9:34 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 05/26] x86/kexec: Make relocate_kernel_64.S objtool clean Peter Zijlstra
2020-03-24 20:55 ` Josh Poimboeuf
2020-03-25 9:56 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 06/26] objtool: Optimize find_symbol_by_index() Peter Zijlstra
2020-03-25 10:01 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 07/26] objtool: Add a statistics mode Peter Zijlstra
2020-03-25 10:10 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 08/26] objtool: Optimize find_section_by_index() Peter Zijlstra
2020-03-25 10:12 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 09/26] objtool: Optimize find_section_by_name() Peter Zijlstra
2020-03-25 10:18 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 10/26] objtool: Optimize find_symbol_*() and read_symbols() Peter Zijlstra
2020-03-25 10:20 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 11/26] objtool: Rename find_containing_func() Peter Zijlstra
2020-03-25 10:21 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 12/26] objtool: Resize insn_hash Peter Zijlstra
2020-03-25 10:21 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 13/26] objtool: Optimize find_symbol_by_name() Peter Zijlstra
2020-03-25 10:25 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 14/26] objtool: Optimize read_sections() Peter Zijlstra
2020-03-25 12:10 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-04-21 14:47 ` [PATCH v3 14/26] " youling257
2020-04-21 15:49 ` Peter Zijlstra
2020-04-21 15:57 ` Borislav Petkov
2020-04-21 17:50 ` youling 257
2020-03-24 15:31 ` [PATCH v3 15/26] objtool: Delete cleanup() Peter Zijlstra
2020-03-25 12:11 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 16/26] objtool: Optimize find_rela_by_dest_range() Peter Zijlstra
2020-03-25 12:19 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 17/26] objtool: Re-arrange validate_functions() Peter Zijlstra
2020-03-24 21:10 ` Josh Poimboeuf
2020-03-24 21:15 ` Peter Zijlstra
2020-03-25 12:22 ` Miroslav Benes
2020-03-26 10:08 ` [tip: core/objtool] " tip-bot2 for Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 18/26] objtool: Fix !CFI insn_state propagation Peter Zijlstra
2020-03-24 21:40 ` Josh Poimboeuf
2020-03-24 22:11 ` Peter Zijlstra
2020-03-24 23:00 ` Peter Zijlstra
2020-03-25 14:39 ` Josh Poimboeuf
2020-03-25 14:41 ` [PATCH v3.1 18a/26] objtool: Remove CFI save/restore special case Peter Zijlstra
2020-03-25 14:42 ` [PATCH v3.1 18b/26] objtool: Factor out CFI hints Peter Zijlstra
2020-03-25 14:43 ` [PATCH v3.1 18c/26] objtool: Rename struct cfi_state Peter Zijlstra
2020-03-25 14:43 ` [PATCH v3.1 18d/26] objtool: Fix !CFI insn_state propagation Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 19/26] objtool: Implement noinstr validation Peter Zijlstra
2020-03-24 21:41 ` Josh Poimboeuf
2020-03-25 14:44 ` [PATCH v3.1 " Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 20/26] objtool: Optimize !vmlinux.o again Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 21/26] objtool: Use sec_offset_hash() for insn_hash Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 22/26] objtool: Detect loading function pointers across noinstr Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 23/26] kbuild/objtool: Add objtool-vmlinux.o pass Peter Zijlstra
2020-03-24 22:03 ` Josh Poimboeuf
2020-03-24 22:05 ` Peter Zijlstra
2020-03-24 15:31 ` [PATCH v3 24/26] objtool: Avoid iterating !text section symbols Peter Zijlstra
2020-03-24 22:09 ` Josh Poimboeuf
2020-03-24 15:31 ` [PATCH v3 25/26] objtool: Rearrange validate_section() Peter Zijlstra
2020-03-24 22:10 ` Josh Poimboeuf
2020-03-24 15:31 ` [PATCH v3 26/26] objtool: Add STT_NOTYPE noinstr validation Peter Zijlstra
2020-03-24 22:16 ` Josh Poimboeuf
2020-03-24 22:34 ` Peter Zijlstra
2020-03-25 14:42 ` Josh Poimboeuf
2020-03-25 15:53 ` Peter Zijlstra
2020-03-25 16:40 ` Josh Poimboeuf
2020-03-25 16:50 ` Peter Zijlstra [this message]
2020-03-26 8:01 ` Julien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325165050.GC20696@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=brgerst@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mhiramat@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).