From: Al Viro <viro@zeniv.linux.org.uk>
To: Qian Cai <cai@lca.pw>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Null-ptr-deref due to "sanitized pathwalk machinery (v4)"
Date: Wed, 25 Mar 2020 21:07:17 +0000 [thread overview]
Message-ID: <20200325210717.GO23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <C2554121-109E-450A-965F-B8DFE2B0E528@lca.pw>
On Wed, Mar 25, 2020 at 03:43:06PM -0400, Qian Cai wrote:
> Since that one has a compilation warning, I have tested this patch and seen no crash so far.
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 311e33dbac63..73851acdbf3a 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -1806,6 +1806,9 @@ static const char *handle_dots(struct nameidata *nd, int type)
> parent, inode, seq);
> }
>
> + if (unlikely(error))
> + return error;
> +
OK, an equivalent of that had been folded into #work.dotdot/#for-next
I'll definitely throw a mentioning of your reporting that thing;
do you want tested-by: added there as well?
next prev parent reply other threads:[~2020-03-25 21:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 21:06 Null-ptr-deref due to "sanitized pathwalk machinery (v4)" Qian Cai
2020-03-24 21:46 ` Al Viro
2020-03-25 1:49 ` Qian Cai
2020-03-25 2:13 ` Al Viro
2020-03-25 3:24 ` Qian Cai
2020-03-25 4:03 ` Al Viro
2020-03-25 5:58 ` Al Viro
2020-03-25 14:02 ` Al Viro
2020-03-25 14:05 ` Al Viro
2020-03-25 19:43 ` Qian Cai
2020-03-25 21:07 ` Al Viro [this message]
2020-03-25 13:21 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325210717.GO23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=cai@lca.pw \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).