* [PATCH] qlcnic: Fix bad kzalloc null test
@ 2020-03-26 10:14 Xu Wang
2020-03-26 18:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2020-03-26 10:14 UTC (permalink / raw)
To: shshaikh, manishc, GR-Linux-NIC-Dev, davem; +Cc: netdev, linux-kernel
In qlcnic_83xx_get_reset_instruction_template, the variable
of null test is bad, so correct it.
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
index 07f9067affc6..cda5b0a9e948 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
@@ -1720,7 +1720,7 @@ static int qlcnic_83xx_get_reset_instruction_template(struct qlcnic_adapter *p_d
ahw->reset.seq_error = 0;
ahw->reset.buff = kzalloc(QLC_83XX_RESTART_TEMPLATE_SIZE, GFP_KERNEL);
- if (p_dev->ahw->reset.buff == NULL)
+ if (ahw->reset.buff == NULL)
return -ENOMEM;
p_buff = p_dev->ahw->reset.buff;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qlcnic: Fix bad kzalloc null test
2020-03-26 10:14 [PATCH] qlcnic: Fix bad kzalloc null test Xu Wang
@ 2020-03-26 18:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-03-26 18:46 UTC (permalink / raw)
To: vulab; +Cc: shshaikh, manishc, GR-Linux-NIC-Dev, netdev, linux-kernel
From: Xu Wang <vulab@iscas.ac.cn>
Date: Thu, 26 Mar 2020 18:14:29 +0800
> In qlcnic_83xx_get_reset_instruction_template, the variable
> of null test is bad, so correct it.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-26 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 10:14 [PATCH] qlcnic: Fix bad kzalloc null test Xu Wang
2020-03-26 18:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).