From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF523C43331 for ; Thu, 26 Mar 2020 18:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF2E020722 for ; Thu, 26 Mar 2020 18:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728335AbgCZSqO (ORCPT ); Thu, 26 Mar 2020 14:46:14 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52618 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727541AbgCZSqO (ORCPT ); Thu, 26 Mar 2020 14:46:14 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2026615CBBAC9; Thu, 26 Mar 2020 11:46:14 -0700 (PDT) Date: Thu, 26 Mar 2020 11:46:13 -0700 (PDT) Message-Id: <20200326.114613.217642686345799497.davem@davemloft.net> To: vulab@iscas.ac.cn Cc: shshaikh@marvell.com, manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qlcnic: Fix bad kzalloc null test From: David Miller In-Reply-To: <20200326101429.18876-1-vulab@iscas.ac.cn> References: <20200326101429.18876-1-vulab@iscas.ac.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Mar 2020 11:46:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xu Wang Date: Thu, 26 Mar 2020 18:14:29 +0800 > In qlcnic_83xx_get_reset_instruction_template, the variable > of null test is bad, so correct it. > > Signed-off-by: Xu Wang Applied, thanks.