From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00259C2D0E9 for ; Thu, 26 Mar 2020 19:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAB3F20658 for ; Thu, 26 Mar 2020 19:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728631AbgCZTHq (ORCPT ); Thu, 26 Mar 2020 15:07:46 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52904 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbgCZTHp (ORCPT ); Thu, 26 Mar 2020 15:07:45 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 11B8115CBC338; Thu, 26 Mar 2020 12:07:43 -0700 (PDT) Date: Thu, 26 Mar 2020 12:07:43 -0700 (PDT) Message-Id: <20200326.120743.1932411612374465145.davem@davemloft.net> To: joe@perches.com Cc: florinel.iordache@nxp.com, netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kuba@kernel.org, corbet@lwn.net, shawnguo@kernel.org, leoyang.li@nxp.com, madalin.bucur@oss.nxp.com, ioana.ciornei@nxp.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 6/9] net: phy: add backplane kr driver support From: David Miller In-Reply-To: <46bf05a81237ed716bf06b48891fcd7c129eae5d.camel@perches.com> References: <1585230682-24417-7-git-send-email-florinel.iordache@nxp.com> <20200326.115330.2250343131621391364.davem@davemloft.net> <46bf05a81237ed716bf06b48891fcd7c129eae5d.camel@perches.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Mar 2020 12:07:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Thu, 26 Mar 2020 11:55:17 -0700 > On Thu, 2020-03-26 at 11:53 -0700, David Miller wrote: >> From: Florinel Iordache >> Date: Thu, 26 Mar 2020 15:51:19 +0200 >> >> > +static void kr_reset_master_lane(struct kr_lane_info *krln) >> > +{ >> > + struct phy_device *bpphy = krln->bpphy; >> > + struct backplane_phy_info *bp_phy = bpphy->priv; >> > + const struct lane_io_ops *lane_ops = krln->bp_phy->bp_dev.lane_ops; >> >> Please use reverse christmas tree ordering for local variables. > > How (any why) do you suggest the first 2 entries here > should be ordered? You have to sometimes put assignments into the code body rather than the declarations in situations like this.