From: Alain Volmat <alain.volmat@st.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pierre Yves MORDRET <pierre-yves.mordret@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre TORGUE <alexandre.torgue@st.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Fabrice GASNIER <fabrice.gasnier@st.com>
Subject: Re: [PATCH 2/2] i2c: i2c-stm32f7: allows for any bus frequency
Date: Thu, 26 Mar 2020 11:12:19 +0100 [thread overview]
Message-ID: <20200326101219.GA21190@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <CAHp75VdPCWdpGo=2n9g0ivti-g2m4jZ=cG4BKHBLk8BVDzaCyg@mail.gmail.com>
Hi Andy,
Thanks for the review.
On Wed, Mar 25, 2020 at 06:53:45PM +0000, Andy Shevchenko wrote:
> On Wed, Mar 25, 2020 at 8:38 PM Alain Volmat <alain.volmat@st.com> wrote:
> >
> > Do not limitate to the 3 (100KHz, 400KHz, 1MHz) bus frequency but
> > instead allows any frequency (if it matches timing requirements).
> > Depending on the requested frequency, use the spec data from either
> > Standard, Fast or Fast Plus mode.
> >
> > Hardcoding of min/max bus frequencies is removed and is instead computed.
> >
> > The driver do not use anymore speed identifier but instead handle
> > directly the frequency and figure out the spec data (necessary
> > for the computation of the timing register) based on the frequency.
>
> ...
>
> > +static struct stm32f7_i2c_spec *get_specs(u32 rate)
> > +{
> > + int i;
> > +
> > + for (i = 0; i < ARRAY_SIZE(i2c_specs); i++)
> > + if (rate <= i2c_specs[i].rate)
> > + return &i2c_specs[i];
> > +
>
> > + /* NOT REACHED */
> > + return ERR_PTR(-EINVAL);
>
> WARN_ONCE() ?
The comment should actually be removed. get_specs return value is
properly checked in stm32f7_i2c_compute_timing and an error message
is displayed in case of an error.
>
> > +}
>
> ...
>
> > - if ((tscl_l < i2c_specs[setup->speed].l_min) ||
> > + if ((tscl_l < specs->l_min) ||
>
> > (i2cclk >=
> > ((tscl_l - af_delay_min - dnf_delay) / 4))) {
>
> Perhaps squash above two to one line at the same time?
I agree that this is not very pretty to read now but that would lead to
a line exceeding 80 characters. To fix that it'd be better to rework the code
but in such case that should be done at a separate time to keep this commit
as small / simpler to understand as possible. So I'd prefer leave this code
for the time being.
>
> ...
>
> > + int i;
> > +
> > + for (i = ARRAY_SIZE(i2c_specs) - 1; i >= 0; i--)
>
>
> Perhaps
>
> int i = ARRAY_SIZE(i2c_specs);
>
> while(i--)
>
> ?
I propose the following code to make it a bit easier to read/understand:
static u32 get_lower_rate(u32 rate)
{
int i = ARRAY_SIZE(i2c_specs);
while (i--)
if (i2c_specs[i].rate < rate)
break;
return i2c_specs[i].rate;
}
If you agree with that I'll push a v2.
>
> > + if (i2c_specs[i].rate < rate)
> > + return i2c_specs[i].rate;
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2020-03-26 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 18:35 [PATCH 0/2] i2c: i2c-stm32f7: allow range of I2C bus frequency Alain Volmat
2020-03-25 18:36 ` [PATCH 1/2] dt-bindings: i2c: i2c-stm32f7: allow clock-frequency range Alain Volmat
2020-03-25 18:36 ` [PATCH 2/2] i2c: i2c-stm32f7: allows for any bus frequency Alain Volmat
2020-03-25 18:53 ` Andy Shevchenko
2020-03-26 10:12 ` Alain Volmat [this message]
2020-03-26 11:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326101219.GA21190@gnbcxd0016.gnb.st.com \
--to=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).