From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 407BAC2D0EE for ; Fri, 27 Mar 2020 04:16:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E296206F1 for ; Fri, 27 Mar 2020 04:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585282595; bh=VRn4CmnO4guCD3v0PtWxBdCVigKH7R2NN/+P9WQ6LhA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=E1tjPue/kJFZWmmg281fPeuUEgo/g8tiujkLKhrEKwiz+uZR/d2QtkATsgS26C0lX r+fPlzbJxD+Y16mTUEi8zBr0elzWm+SoHkGi8dm1yXviK7gWDmFUNth8QLA6HDflrb cRtwcwBioYdeTJrBG384Qf13rrl88YMsRHtEbU18= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726439AbgC0EQd (ORCPT ); Fri, 27 Mar 2020 00:16:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:56624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgC0EQc (ORCPT ); Fri, 27 Mar 2020 00:16:32 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 025A920578; Fri, 27 Mar 2020 04:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585282592; bh=VRn4CmnO4guCD3v0PtWxBdCVigKH7R2NN/+P9WQ6LhA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2dgPZUxTe0hmf+l3SsoeBLj329rzs1nPoy5RXCid7+x7zbHLD2+rGx5Zs9wPe4Ds7 +4hm6xa1wdBJfO9t6Fe4bq8sLttnuv7dAOjjO23RFSn4lZ7CovBOrmX8SPHT8rUcYO HKGKR9DqamA1hJqoK5W+3L9hxTrPF9BjduDEmdOE= Date: Thu, 26 Mar 2020 21:16:30 -0700 From: Jakub Kicinski To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 03/12] ethtool: set coalescing parameters with COALESCE_SET request Message-ID: <20200326211630.41e0329c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2020 01:12:02 +0100 (CET) Michal Kubecek wrote: > Implement COALESCE_SET netlink request to set coalescing parameters of > a network device. These are traditionally set with ETHTOOL_SCOALESCE ioctl > request. This commit adds only support for device coalescing parameters, > not per queue coalescing parameters. > > Like the ioctl implementation, the generic ethtool code checks if only > supported parameters are modified; if not, first offending attribute is > reported using extack. > > Signed-off-by: Michal Kubecek Reviewed-by: Jakub Kicinski