From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH 3/3] f2fs: fix to check f2fs_compressed_file() in f2fs_bmap()
Date: Fri, 27 Mar 2020 12:32:33 -0700 [thread overview]
Message-ID: <20200327193233.GB186975@google.com> (raw)
In-Reply-To: <20200327102953.104035-3-yuchao0@huawei.com>
On 03/27, Chao Yu wrote:
> Otherwise, for compressed inode, returned physical block address
> may be wrong.
We can use bmap to check the allocated (non)compressed blocks.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/data.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 24643680489b..f22f3ba10a48 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -3591,6 +3591,8 @@ static sector_t f2fs_bmap(struct address_space *mapping, sector_t block)
>
> if (f2fs_has_inline_data(inode))
> return 0;
> + if (f2fs_compressed_file(inode))
> + return 0;
>
> /* make sure allocating whole blocks */
> if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY))
> --
> 2.18.0.rc1
next prev parent reply other threads:[~2020-03-27 19:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 10:29 [PATCH 1/3] f2fs: fix to disable compression on directory Chao Yu
2020-03-27 10:29 ` [PATCH 2/3] f2fs: keep inline_data when compression conversion Chao Yu
2020-03-27 10:29 ` [PATCH 3/3] f2fs: fix to check f2fs_compressed_file() in f2fs_bmap() Chao Yu
2020-03-27 19:32 ` Jaegeuk Kim [this message]
2020-03-28 8:38 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327193233.GB186975@google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).