From: Michal Kubecek <mkubecek@suse.cz>
To: netdev@vger.kernel.org
Cc: Richard Cochran <richardcochran@gmail.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
John Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 11/12] ethtool: add timestamping related string sets
Date: Fri, 27 Mar 2020 20:43:54 +0100 [thread overview]
Message-ID: <20200327194354.GI31519@unicorn.suse.cz> (raw)
In-Reply-To: <20200327185344.GA28023@localhost>
On Fri, Mar 27, 2020 at 11:53:44AM -0700, Richard Cochran wrote:
> On Fri, Mar 27, 2020 at 03:08:12PM +0100, Michal Kubecek wrote:
> > +const char ts_tx_type_names[][ETH_GSTRING_LEN] = {
> > + [HWTSTAMP_TX_OFF] = "off",
> > + [HWTSTAMP_TX_ON] = "on",
> > + [HWTSTAMP_TX_ONESTEP_SYNC] = "one-step-sync",
> > + [HWTSTAMP_TX_ONESTEP_P2P] = "one-step-p2p",
> > +};
>
> Suggest "onestep-sync" and "onestep-p2p".
I copied "one-step-sync" from (userspace) ethtool but I guess we don't
have to be 100% backward compatible. It would match the constant name
better without dash.
Michal
> Acked-by: Richard Cochran <richardcochran@gmail.com>
next prev parent reply other threads:[~2020-03-27 19:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 14:07 [PATCH net-next v2 00/12] ethtool netlink interface, part 4 Michal Kubecek
2020-03-27 14:07 ` [PATCH net-next v2 01/12] ethtool: fix reference leak in ethnl_set_privflags() Michal Kubecek
2020-03-27 14:07 ` [PATCH net-next v2 02/12] ethtool: provide coalescing parameters with COALESCE_GET request Michal Kubecek
2020-03-27 14:07 ` [PATCH net-next v2 03/12] ethtool: set coalescing parameters with COALESCE_SET request Michal Kubecek
2020-03-27 14:07 ` [PATCH net-next v2 04/12] ethtool: add COALESCE_NTF notification Michal Kubecek
2020-03-27 14:07 ` [PATCH net-next v2 05/12] ethtool: provide pause parameters with PAUSE_GET request Michal Kubecek
2020-03-27 14:07 ` [PATCH net-next v2 06/12] ethtool: set pause parameters with PAUSE_SET request Michal Kubecek
2020-03-27 14:07 ` [PATCH net-next v2 07/12] ethtool: add PAUSE_NTF notification Michal Kubecek
2020-03-27 14:07 ` [PATCH net-next v2 08/12] ethtool: provide EEE settings with EEE_GET request Michal Kubecek
2020-03-27 14:08 ` [PATCH net-next v2 09/12] ethtool: set EEE settings with EEE_SET request Michal Kubecek
2020-03-27 14:08 ` [PATCH net-next v2 10/12] ethtool: add EEE_NTF notification Michal Kubecek
2020-03-27 14:08 ` [PATCH net-next v2 11/12] ethtool: add timestamping related string sets Michal Kubecek
2020-03-27 18:53 ` Richard Cochran
2020-03-27 19:43 ` Michal Kubecek [this message]
2020-03-27 14:08 ` [PATCH net-next v2 12/12] ethtool: provide timestamping information with TIMESTAMP_GET request Michal Kubecek
2020-03-27 18:56 ` Richard Cochran
2020-03-27 19:45 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327194354.GI31519@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).