From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8609BC43331 for ; Fri, 27 Mar 2020 22:15:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 505FC206DB for ; Fri, 27 Mar 2020 22:15:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p9SBNdR+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727719AbgC0WPu (ORCPT ); Fri, 27 Mar 2020 18:15:50 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:42506 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726781AbgC0WPu (ORCPT ); Fri, 27 Mar 2020 18:15:50 -0400 Received: by mail-pg1-f195.google.com with SMTP id h8so5237172pgs.9 for ; Fri, 27 Mar 2020 15:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TEwTFJQjvV6Mx5spN7GpwpVz8q19VnSJjUr5y2zOQf4=; b=p9SBNdR+ETIPSTXcv5EhsgX4tSQOTcZTMdhoZo/8WYUG+a++O1VV0uJ6+modK5pxzh HMITDpSbUK0bPjS+gKppaVH4D6idOVczgD3d/rfavsXFgmDbsSJQAGgO9g/wkbGj3kMn PnoH2d0IKUqvRfBtogvE07RRc5sijJBwuAmz6F4pNACVZD6o+Mc83UJ+FzcaLxBAqyQI JEzwo+ApKOBsJjORG+54L5O8FR8LRtj8oNjw+d2rQkVunVbiKXhFKn+DoUdiBKTsd6HE 98xUG1mGuTYvcEEnUlVpqZitjoQ4FiNZPwhkJiMYBdyB98fu1AMII5hzw/KR4Tjb14iI 4KSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TEwTFJQjvV6Mx5spN7GpwpVz8q19VnSJjUr5y2zOQf4=; b=qZTXH682lZmDZKK8B+Ym55MrbbixExpS00Opb3FOF+/DGVfR890qNSUoGpauIJN5+E BlAkmzfSLgam3xvc77tFyadJAugkB0sqS6f/yWCP7SOEYWvoMdIQooyV6kmob2ny2m0n MWtgvsXdTqR8r+O1v8xZGyVvVMm5Wf0KlIOM73J0IAXM1SlfxDCok/hBiYeg17FD2BLt wHHJhco3u0DN1dprDa22xxyvAJhPGAU9tO011WNGxWRDmgA9l36cIIDQsG0XqkbWiocU wbqHG7kWDk5bmf3USfZJmMmieJ7w8vJCh1iPO5UJTNz8HRg2kdkpdQCY6vKPaSZgufvN Dncw== X-Gm-Message-State: ANhLgQ14q0LPbQL3W6eNhcSPzBLOlNo2HdcpC/5sAWPu3dWOO3fG8ZKv ysyKeStfz7Ezu5FgOE26XHCfgQ== X-Google-Smtp-Source: ADFU+vud/GGU22qfW9z9qf0DG+nmWdPXJx314vADEi1cJKcHiCmBXY49eDWGGyDc8y3g/2VXMAR/aw== X-Received: by 2002:a63:a65:: with SMTP id z37mr1441563pgk.31.1585347348852; Fri, 27 Mar 2020 15:15:48 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id r4sm4564372pgp.53.2020.03.27.15.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 15:15:47 -0700 (PDT) Date: Fri, 27 Mar 2020 15:15:45 -0700 From: Bjorn Andersson To: Thara Gopinath Cc: rui.zhang@intel.com, ulf.hansson@linaro.org, daniel.lezcano@linaro.org, agross@kernel.org, robh@kernel.org, amit.kucheria@verdurent.com, mark.rutland@arm.com, rjw@rjwysocki.net, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v5 2/6] soc: qcom: rpmhpd: Introduce function to retrieve power domain performance state count Message-ID: <20200327221545.GF5063@builder> References: <20200320014107.26087-1-thara.gopinath@linaro.org> <20200320014107.26087-3-thara.gopinath@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320014107.26087-3-thara.gopinath@linaro.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 19 Mar 18:41 PDT 2020, Thara Gopinath wrote: > Populate .get_performace_state_count in genpd ops to retrieve the count of > performance states supported by a rpmh power domain. > > Reviewed-by: Ulf Hansson > Signed-off-by: Thara Gopinath > --- > drivers/soc/qcom/rpmhpd.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c > index 4d264d0672c4..7142409a3b77 100644 > --- a/drivers/soc/qcom/rpmhpd.c > +++ b/drivers/soc/qcom/rpmhpd.c > @@ -341,6 +341,13 @@ static unsigned int rpmhpd_get_performance_state(struct generic_pm_domain *genpd > return dev_pm_opp_get_level(opp); > } > > +static int rpmhpd_performance_states_count(struct generic_pm_domain *domain) > +{ > + struct rpmhpd *pd = domain_to_rpmhpd(domain); > + > + return pd->level_count; > +} > + > static int rpmhpd_update_level_mapping(struct rpmhpd *rpmhpd) > { > int i; > @@ -429,6 +436,8 @@ static int rpmhpd_probe(struct platform_device *pdev) > rpmhpds[i]->pd.power_on = rpmhpd_power_on; > rpmhpds[i]->pd.set_performance_state = rpmhpd_set_performance_state; > rpmhpds[i]->pd.opp_to_performance_state = rpmhpd_get_performance_state; > + rpmhpds[i]->pd.get_performance_state_count = > + rpmhpd_performance_states_count; I would prefer if you ignore the 80-char limit here and leave the line unwrapped. Reviewed-by: Bjorn Andersson Regards, Bjorn > pm_genpd_init(&rpmhpds[i]->pd, NULL, true); > > data->domains[i] = &rpmhpds[i]->pd; > -- > 2.20.1 >