* [RFC PATCH v1 25/50] HID: hid-lg: We only need pseudorandom bytes for the address
@ 2019-03-27 12:27 George Spelvin
0 siblings, 0 replies; only message in thread
From: George Spelvin @ 2019-03-27 12:27 UTC (permalink / raw)
To: linux-kernel, lkml
Cc: Simon Wood, Hans de Goede, Jiri Kosina, Benjamin Tissoires
It's just to reduce collisions among cooperating USB HID
devices; it's not intended to be secure against a malicious
attacker (and it would need to be a lot larger than 16 bits
if it were).
Signed-off-by: George Spelvin <lkml@sdf.org>
Cc: Simon Wood <simon@mungewell.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-lg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index 0dc7cdfc56f77..b6b6ed9834c7c 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -832,7 +832,7 @@ static int lg_probe(struct hid_device *hdev, const struct hid_device_id *id)
/* Select random Address */
buf[1] = 0xB2;
- get_random_bytes(&buf[2], 2);
+ prandom_bytes(buf+2, 2);
ret = hid_hw_raw_request(hdev, buf[0], buf, sizeof(cbuf),
HID_FEATURE_REPORT, HID_REQ_SET_REPORT);
--
2.26.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-28 16:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-27 12:27 [RFC PATCH v1 25/50] HID: hid-lg: We only need pseudorandom bytes for the address George Spelvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).