From: kbuild test robot <lkp@intel.com>
To: vladimir.stankovic@displaylink.com
Cc: kbuild-all@lists.01.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
mausb-host-devel@displaylink.com
Subject: Re: [PATCH v4 7/8] usb: mausb_host: MA-USB PAL events processing
Date: Sat, 28 Mar 2020 18:35:47 +0800 [thread overview]
Message-ID: <202003281831.I3CbcEGP%lkp@intel.com> (raw)
In-Reply-To: <20200327152614.26833-8-vladimir.stankovic@displaylink.com>
[-- Attachment #1: Type: text/plain, Size: 9163 bytes --]
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on balbi-usb/next peter.chen-usb/ci-for-usb-next linus/master linux/master v5.6-rc7 next-20200327]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/vladimir-stankovic-displaylink-com/Add-MA-USB-Host-driver/20200328-042436
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:15,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from include/linux/spinlock.h:51,
from include/linux/kref.h:16,
from drivers/usb/mausb_host/hpal.h:8,
from drivers/usb/mausb_host/utils.h:8,
from drivers/usb/mausb_host/utils.c:5:
drivers/usb/mausb_host/utils.c: In function 'mausb_file_read':
>> include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'ssize_t' {aka 'int'} [-Wformat=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/kern_levels.h:9:20: note: in expansion of macro 'KERN_SOH'
9 | #define KERN_ALERT KERN_SOH "1" /* action must be taken immediately */
| ^~~~~~~~
include/linux/printk.h:300:9: note: in expansion of macro 'KERN_ALERT'
300 | printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~
>> drivers/usb/mausb_host/utils.h:16:2: note: in expansion of macro 'pr_alert'
16 | pr_##level_str("MAUSB " #level " [%x:%x] [%s] " log "\n",\
| ^~~
>> drivers/usb/mausb_host/utils.h:20:29: note: in expansion of macro 'mausb_pr_logs'
20 | #define mausb_pr_alert(...) mausb_pr_logs(alert, 1, ##__VA_ARGS__)
| ^~~~~~~~~~~~~
>> drivers/usb/mausb_host/utils.c:102:3: note: in expansion of macro 'mausb_pr_alert'
102 | mausb_pr_alert("Different expected bytes to read (%ld) from actual size (%ld)",
| ^~~~~~~~~~~~~~
include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/kern_levels.h:9:20: note: in expansion of macro 'KERN_SOH'
9 | #define KERN_ALERT KERN_SOH "1" /* action must be taken immediately */
| ^~~~~~~~
include/linux/printk.h:300:9: note: in expansion of macro 'KERN_ALERT'
300 | printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~
>> drivers/usb/mausb_host/utils.h:16:2: note: in expansion of macro 'pr_alert'
16 | pr_##level_str("MAUSB " #level " [%x:%x] [%s] " log "\n",\
| ^~~
>> drivers/usb/mausb_host/utils.h:20:29: note: in expansion of macro 'mausb_pr_logs'
20 | #define mausb_pr_alert(...) mausb_pr_logs(alert, 1, ##__VA_ARGS__)
| ^~~~~~~~~~~~~
>> drivers/usb/mausb_host/utils.c:102:3: note: in expansion of macro 'mausb_pr_alert'
102 | mausb_pr_alert("Different expected bytes to read (%ld) from actual size (%ld)",
| ^~~~~~~~~~~~~~
drivers/usb/mausb_host/utils.c: In function 'mausb_file_write':
>> include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'ssize_t' {aka 'int'} [-Wformat=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/kern_levels.h:9:20: note: in expansion of macro 'KERN_SOH'
9 | #define KERN_ALERT KERN_SOH "1" /* action must be taken immediately */
| ^~~~~~~~
include/linux/printk.h:300:9: note: in expansion of macro 'KERN_ALERT'
300 | printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~
>> drivers/usb/mausb_host/utils.h:16:2: note: in expansion of macro 'pr_alert'
16 | pr_##level_str("MAUSB " #level " [%x:%x] [%s] " log "\n",\
| ^~~
>> drivers/usb/mausb_host/utils.h:20:29: note: in expansion of macro 'mausb_pr_logs'
20 | #define mausb_pr_alert(...) mausb_pr_logs(alert, 1, ##__VA_ARGS__)
| ^~~~~~~~~~~~~
drivers/usb/mausb_host/utils.c:193:3: note: in expansion of macro 'mausb_pr_alert'
193 | mausb_pr_alert("Different expected bytes to write (%ld) from actual size (%ld)",
| ^~~~~~~~~~~~~~
include/linux/kern_levels.h:5:18: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/kern_levels.h:9:20: note: in expansion of macro 'KERN_SOH'
9 | #define KERN_ALERT KERN_SOH "1" /* action must be taken immediately */
| ^~~~~~~~
include/linux/printk.h:300:9: note: in expansion of macro 'KERN_ALERT'
300 | printk(KERN_ALERT pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~
>> drivers/usb/mausb_host/utils.h:16:2: note: in expansion of macro 'pr_alert'
16 | pr_##level_str("MAUSB " #level " [%x:%x] [%s] " log "\n",\
| ^~~
>> drivers/usb/mausb_host/utils.h:20:29: note: in expansion of macro 'mausb_pr_logs'
20 | #define mausb_pr_alert(...) mausb_pr_logs(alert, 1, ##__VA_ARGS__)
| ^~~~~~~~~~~~~
drivers/usb/mausb_host/utils.c:193:3: note: in expansion of macro 'mausb_pr_alert'
193 | mausb_pr_alert("Different expected bytes to write (%ld) from actual size (%ld)",
| ^~~~~~~~~~~~~~
--
drivers/usb/mausb_host/hpal_events.c: In function 'mausb_data_msg_received_event':
>> drivers/usb/mausb_host/hpal_events.c:44:27: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
44 | event->data.recv_buf = (u64)hdr;
| ^
drivers/usb/mausb_host/hpal_events.c: In function 'mausb_isoch_msg_received_event':
drivers/usb/mausb_host/hpal_events.c:66:27: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
66 | event->data.recv_buf = (u64)hdr;
| ^
drivers/usb/mausb_host/hpal_events.c: In function 'mausb_cleanup_delete_data_transfer_event':
>> drivers/usb/mausb_host/hpal_events.c:593:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
593 | struct urb *urb = (struct urb *)event->data.urb;
| ^
vim +/pr_alert +16 drivers/usb/mausb_host/utils.h
5f578d5631444d vladimir.stankovic@displaylink.com 2020-03-27 9
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 10 #if defined(MAUSB_NO_LOGS)
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 11 #define mausb_pr_logs(...)
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 12 #else
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 13 #include <linux/printk.h>
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 14 #include <linux/sched.h>
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 15 #define mausb_pr_logs(level_str, level, log, ...)\
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 @16 pr_##level_str("MAUSB " #level " [%x:%x] [%s] " log "\n",\
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 17 current->pid, current->tgid, __func__, ##__VA_ARGS__)
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 18 #endif /* MAUSB_NO_LOGS */
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 19
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 @20 #define mausb_pr_alert(...) mausb_pr_logs(alert, 1, ##__VA_ARGS__)
cca4e12f279232 vladimir.stankovic@displaylink.com 2020-03-27 21
:::::: The code at line 16 was first introduced by commit
:::::: cca4e12f279232d69e2a551b72966976d5cda619 usb: Add MA-USB Host kernel module
:::::: TO: vladimir.stankovic@displaylink.com <vladimir.stankovic@displaylink.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51707 bytes --]
next prev parent reply other threads:[~2020-03-28 10:36 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 14:42 [PATCH v3 0/8] Add MA USB Host driver Vladimir Stankovic
2020-03-27 15:26 ` [PATCH v4 " vladimir.stankovic
2020-03-27 15:26 ` [PATCH v4 1/8] usb: Add MA-USB Host kernel module vladimir.stankovic
2020-03-27 16:25 ` Alan Stern
2020-03-27 15:26 ` [PATCH v4 2/8] usb: mausb_host: Add link layer implementation vladimir.stankovic
2020-03-27 15:26 ` [PATCH v4 3/8] usb: mausb_host: HCD initialization vladimir.stankovic
2020-03-27 15:26 ` [PATCH v4 4/8] usb: mausb_host: Implement initial hub handlers vladimir.stankovic
2020-03-27 16:37 ` Alan Stern
2020-04-13 15:16 ` Vladimir Stankovic
2020-03-27 15:26 ` [PATCH v4 5/8] usb: mausb_host: Introduce PAL processing vladimir.stankovic
2020-03-27 16:35 ` Alan Stern
2020-03-28 3:56 ` kbuild test robot
2020-03-27 15:26 ` [PATCH v4 6/8] usb: mausb_host: Add logic for PAL-to-PAL communication vladimir.stankovic
2020-03-27 15:26 ` [PATCH v4 7/8] usb: mausb_host: MA-USB PAL events processing vladimir.stankovic
2020-03-28 10:35 ` kbuild test robot [this message]
2020-04-04 16:07 ` kbuild test robot
2020-03-27 15:26 ` [PATCH v4 8/8] usb: mausb_host: Process MA-USB data packets vladimir.stankovic
2020-04-25 9:19 ` [PATCH v5 0/8] Add MA USB Host driver vladimir.stankovic
2020-04-25 9:19 ` [PATCH v5 1/8] usb: Add MA-USB Host kernel module vladimir.stankovic
2020-04-28 11:03 ` Greg KH
2020-04-25 9:19 ` [PATCH v5 2/8] usb: mausb_host: Add link layer implementation vladimir.stankovic
2020-04-25 9:19 ` [PATCH v5 3/8] usb: mausb_host: HCD initialization vladimir.stankovic
2020-04-28 11:07 ` Greg KH
2020-04-25 9:19 ` [PATCH v5 4/8] usb: mausb_host: Implement initial hub handlers vladimir.stankovic
2020-04-25 9:19 ` [PATCH v5 5/8] usb: mausb_host: Introduce PAL processing vladimir.stankovic
2020-04-26 0:32 ` Alan Stern
2020-04-26 12:32 ` Vladimir Stankovic
2020-04-26 14:31 ` Alan Stern
2020-04-26 14:45 ` [External] " Vladimir Stankovic
2020-04-26 20:56 ` Alan Stern
2020-04-30 14:37 ` Vladimir Stankovic
2020-04-30 15:18 ` Alan Stern
2020-04-30 15:34 ` Vladimir Stankovic
2020-04-30 15:41 ` Alan Stern
2020-04-25 9:19 ` [PATCH v5 6/8] usb: mausb_host: Add logic for PAL-to-PAL communication vladimir.stankovic
2020-04-25 9:19 ` [PATCH v5 7/8] usb: mausb_host: MA-USB PAL events processing vladimir.stankovic
2020-04-28 11:08 ` Greg KH
2020-04-25 9:19 ` [PATCH v5 8/8] usb: mausb_host: Process MA-USB data packets vladimir.stankovic
2020-04-28 11:04 ` [PATCH v5 0/8] Add MA USB Host driver Greg KH
2020-04-30 16:51 ` [External] " Vladimir Stankovic
2020-04-30 20:02 ` Greg KH
2020-05-15 13:04 ` Vladimir Stankovic
2020-05-29 12:48 ` Pavel Machek
2020-05-15 12:34 ` [PATCH v6 " Vladimir Stankovic
2020-05-15 12:34 ` [PATCH v6 1/8] usb: Add MA-USB Host kernel module Vladimir Stankovic
2020-05-15 13:01 ` Greg KH
2020-06-11 18:20 ` Vladimir Stankovic
2020-05-15 13:02 ` Greg KH
2020-06-11 18:19 ` [External] " Vladimir Stankovic
2020-05-15 12:34 ` [PATCH v6 2/8] usb: mausb_host: Add link layer implementation Vladimir Stankovic
2020-05-15 12:34 ` [PATCH v6 3/8] usb: mausb_host: HCD initialization Vladimir Stankovic
2020-05-15 13:03 ` Greg KH
2020-06-11 18:19 ` Vladimir Stankovic
2020-05-15 13:07 ` Greg KH
2020-06-11 18:18 ` [External] " Vladimir Stankovic
2020-06-18 8:18 ` Greg KH
2020-05-15 12:34 ` [PATCH v6 4/8] usb: mausb_host: Implement initial hub handlers Vladimir Stankovic
2020-05-15 12:34 ` [PATCH v6 5/8] usb: mausb_host: Introduce PAL processing Vladimir Stankovic
2020-05-15 12:35 ` [PATCH v6 6/8] usb: mausb_host: Add logic for PAL-to-PAL communication Vladimir Stankovic
2020-05-15 12:35 ` [PATCH v6 7/8] usb: mausb_host: MA-USB PAL events processing Vladimir Stankovic
2020-05-15 12:35 ` [PATCH v6 8/8] usb: mausb_host: Process MA-USB data packets Vladimir Stankovic
2020-05-15 13:08 ` [PATCH v6 0/8] Add MA USB Host driver Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003281831.I3CbcEGP%lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mausb-host-devel@displaylink.com \
--cc=vladimir.stankovic@displaylink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).