* [PATCH] iio: buffer: drop left-over 'stufftoread' field
@ 2020-03-28 16:34 Alexandru Ardelean
2020-03-29 9:40 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Ardelean @ 2020-03-28 16:34 UTC (permalink / raw)
To: linux-iio, linux-kernel; +Cc: jic23, lars, Alexandru Ardelean
This seems like a left-over from a7348347ba8a4 ("staging:iio: Add polling
of events on the ring access chrdev.").
Then it was moved into the sca3000 driver around 9dd4694dafbd8 ("iio:
staging: sca3000: hide stufftoread logic"), and that one seemed to be the
only user of this.
Then it eventually was no longer used after 152a6a884ae1
("staging:iio:accel:sca3000 move to hybrid hard / soft buffer design.")
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
include/linux/iio/buffer_impl.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/iio/buffer_impl.h b/include/linux/iio/buffer_impl.h
index a4d2d8061ef6..1e7edf6bed96 100644
--- a/include/linux/iio/buffer_impl.h
+++ b/include/linux/iio/buffer_impl.h
@@ -115,9 +115,6 @@ struct iio_buffer {
*/
struct attribute_group scan_el_group;
- /* @stufftoread: Flag to indicate new data. */
- bool stufftoread;
-
/* @attrs: Standard attributes of the buffer. */
const struct attribute **attrs;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: buffer: drop left-over 'stufftoread' field
2020-03-28 16:34 [PATCH] iio: buffer: drop left-over 'stufftoread' field Alexandru Ardelean
@ 2020-03-29 9:40 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-03-29 9:40 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-iio, linux-kernel, lars
On Sat, 28 Mar 2020 18:34:21 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> This seems like a left-over from a7348347ba8a4 ("staging:iio: Add polling
> of events on the ring access chrdev.").
>
> Then it was moved into the sca3000 driver around 9dd4694dafbd8 ("iio:
> staging: sca3000: hide stufftoread logic"), and that one seemed to be the
> only user of this.
>
> Then it eventually was no longer used after 152a6a884ae1
> ("staging:iio:accel:sca3000 move to hybrid hard / soft buffer design.")
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Oops.
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> include/linux/iio/buffer_impl.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/iio/buffer_impl.h b/include/linux/iio/buffer_impl.h
> index a4d2d8061ef6..1e7edf6bed96 100644
> --- a/include/linux/iio/buffer_impl.h
> +++ b/include/linux/iio/buffer_impl.h
> @@ -115,9 +115,6 @@ struct iio_buffer {
> */
> struct attribute_group scan_el_group;
>
> - /* @stufftoread: Flag to indicate new data. */
> - bool stufftoread;
> -
> /* @attrs: Standard attributes of the buffer. */
> const struct attribute **attrs;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-29 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-28 16:34 [PATCH] iio: buffer: drop left-over 'stufftoread' field Alexandru Ardelean
2020-03-29 9:40 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).