From: Jason Gunthorpe <jgg@ziepe.ca>
To: George Spelvin <lkml@SDF.ORG>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
Dennis Dalessandro <dennis.dalessandro@intel.com>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
linux-rdma@vger.kernel.org
Subject: Re: [RFC PATCH v1 01/50] IB/qib: Delete struct qib_ivdev.qp_rnd
Date: Mon, 30 Mar 2020 13:49:12 -0300 [thread overview]
Message-ID: <20200330164912.GK20941@ziepe.ca> (raw)
In-Reply-To: <20200330164333.GB2459@SDF.ORG>
On Mon, Mar 30, 2020 at 04:43:33PM +0000, George Spelvin wrote:
> On Mon, Mar 30, 2020 at 02:28:08PM +0100, Mark Rutland wrote:
> > Also, if you do send a series, *please* add a cover-letter explaining
> > what the overall purpose of the series is, and have all patches chained
> > in-reply-to that rather than patch 1. Otherwise reviewers have to
> > reverse-engineer the intent of the author.
> >
> > You can generate the cover letter with:
> >
> > $ git format-patch --cover $FROM..$TO
> >
> > ... and IIRC git send-email does the right thing by default if you hand
> > it all of the patches at once.
>
> Er, I *did* send a cover letter. Cc:ed to the union of everyone
> Cc:ed on any of the individual patches. It's appended. (I left in
> the full Cc: list so you can see you're on it.)
>
> My problem is I don't have git on my e-mail machine, so I fed them to
> sendmail manually, and that does some strange things.
The problem is that none of the patches had a in-reply-to header to
the cover letter so it is very difficult to find it.
Things work best if you can use git send-email :) I've never tried it,
bu I wonder if you can tell git that the sendmail is 'ssh foo-server
/usr/bin/sendmail' ?
Jason
next prev parent reply other threads:[~2020-03-30 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 16:55 [RFC PATCH v1 01/50] IB/qib: Delete struct qib_ivdev.qp_rnd George Spelvin
2020-03-29 14:17 ` Jason Gunthorpe
2020-03-29 16:08 ` George Spelvin
2020-03-30 13:28 ` Mark Rutland
2020-03-30 16:43 ` George Spelvin
2020-03-30 16:49 ` Jason Gunthorpe [this message]
2020-04-01 12:26 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330164912.GK20941@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dennis.dalessandro@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkml@SDF.ORG \
--cc=mark.rutland@arm.com \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).