linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net/bpfilter: remove superfluous testing message
@ 2020-03-31 13:06 Bruno Meneguele
  2020-03-31 17:08 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Bruno Meneguele @ 2020-03-31 13:06 UTC (permalink / raw)
  To: netdev, bpf, linux-kernel; +Cc: davem, micron10, ast, Bruno Meneguele

A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
usage for /dev/kmsg") but should've been deleted before patch submission.
Although it doesn't cause any harm to the code or functionality itself, it's
totally unpleasant to have it displayed on every loop iteration with no real
use case. Thus remove it unconditionally.

Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
---
 net/bpfilter/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c
index efea4874743e..05e1cfc1e5cd 100644
--- a/net/bpfilter/main.c
+++ b/net/bpfilter/main.c
@@ -35,7 +35,6 @@ static void loop(void)
 		struct mbox_reply reply;
 		int n;
 
-		fprintf(debug_f, "testing the buffer\n");
 		n = read(0, &req, sizeof(req));
 		if (n != sizeof(req)) {
 			fprintf(debug_f, "invalid request %d\n", n);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/bpfilter: remove superfluous testing message
  2020-03-31 13:06 [PATCH] net/bpfilter: remove superfluous testing message Bruno Meneguele
@ 2020-03-31 17:08 ` David Miller
  2020-04-07  8:04   ` Thomas Lamprecht
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2020-03-31 17:08 UTC (permalink / raw)
  To: bmeneg; +Cc: netdev, bpf, linux-kernel, micron10, ast

From: Bruno Meneguele <bmeneg@redhat.com>
Date: Tue, 31 Mar 2020 10:06:30 -0300

> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
> usage for /dev/kmsg") but should've been deleted before patch submission.
> Although it doesn't cause any harm to the code or functionality itself, it's
> totally unpleasant to have it displayed on every loop iteration with no real
> use case. Thus remove it unconditionally.
> 
> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
> Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/bpfilter: remove superfluous testing message
  2020-03-31 17:08 ` David Miller
@ 2020-04-07  8:04   ` Thomas Lamprecht
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2020-04-07  8:04 UTC (permalink / raw)
  To: David Miller, bmeneg; +Cc: netdev, bpf, linux-kernel, stable

On 3/31/20 7:08 PM, David Miller wrote:
> From: Bruno Meneguele <bmeneg@redhat.com>
> Date: Tue, 31 Mar 2020 10:06:30 -0300
> 
>> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
>> usage for /dev/kmsg") but should've been deleted before patch submission.
>> Although it doesn't cause any harm to the code or functionality itself, it's
>> totally unpleasant to have it displayed on every loop iteration with no real
>> use case. Thus remove it unconditionally.
>>
>> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
>> Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
> 
> Applied, thanks.
> 

As the commit this fixes was included in a stable release (at least 5.4.29[0],
I did not checked others - sorry) it could make sense to backport this also
to the 5.4 stable tree?

Per documentation[1], I checked the netdev and Greg's queues, but did not found
it to be included anywhere yet.

I hope I handled this request somewhat correctly, please tell me if I should
propose the backported patch more directly to the respective stable list. As is,
the patch[2] applies fine here on top of 5.4.30.

cheers,
Thomas

[0]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.4.y&id=712c39d9319a864b74b44fd03b0e083afa2d8af2
[1]: https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-how-can-i-tell-what-patches-are-queued-up-for-backporting-to-the-various-stable-releases
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/patch/?id=41c55ea6c2a7ca4c663eeec05bdf54f4e2419699


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-07  8:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 13:06 [PATCH] net/bpfilter: remove superfluous testing message Bruno Meneguele
2020-03-31 17:08 ` David Miller
2020-04-07  8:04   ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).