From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BBACC2D0E9 for ; Tue, 31 Mar 2020 01:04:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3DDE2054F for ; Tue, 31 Mar 2020 01:04:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rp3DjIoL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729448AbgCaBEG (ORCPT ); Mon, 30 Mar 2020 21:04:06 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36420 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729035AbgCaBEF (ORCPT ); Mon, 30 Mar 2020 21:04:05 -0400 Received: by mail-wm1-f68.google.com with SMTP id g62so814427wme.1 for ; Mon, 30 Mar 2020 18:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Fw2LMhqMpUKtHzYbQVOA9bjQOm3X2jbwN5CrhUGESVY=; b=rp3DjIoLk0LM8SIxOuGq5sbJ4rPhWrk5QsErQqD0bL+5tNrJg1LIvspg8AZyyH2r5X pT2ta0nzDwpHBnGmQiIEx1jxbjMA29SZzy1bFfQqrGCSSZN9DQWuoXn6Us3JRAg8GFj8 t73zUdAnwyE7z/ECeluUAfhIpIrVCCmcewk9UKiDPXXZGHsG+IfrjQ4zQYxz6v8d0B7e hF7Ys/uNmD+HL1BhS8FgONzC2g6cdEcZukRTyMg4tKbiBp/Sg250tOJ+stSqXDeBHnF2 w+4lJl8svCssSiM5FHbrphE8WZv4lMPVcSFbB9zdTUPoK5x2kkTnUjBxO9SPenWAlWoq sL3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Fw2LMhqMpUKtHzYbQVOA9bjQOm3X2jbwN5CrhUGESVY=; b=ra//3RXNmk6W2k93WSHKNFME/1xnEXdVZfQ3nrdwUZF48DrzZ0Q+6cxks6CnIee2q1 wRO6I+DjRlk0btxVSkNSLC0OjpaXkHm28XW21kPoROZQ7elXrbEe4CI79A0MuUiiGqLU zALmfaBGamKnWoLLoyOHwVSXs9j8IlSpBmJOKYbEDfSRUeka0NjxFmBpAQi9YPlhPxwK P74OYspjfZZnDcBNl5PoAlzFoOBB7p6eZVExLtn16DTsEWtXBCCS/CKkui9s9KHyx6YX oX0gBxj0vjgJdb9dI+1eLtEiPErYIhOGHRMWMwSdQE3YwqGf5rNLgbjtTG5YOLpCr/Al ASyw== X-Gm-Message-State: ANhLgQ1s+X96vECIJS6Rt0Qu+H2Krijz8Moyv5LFObmA4L64n5Bi6R4a 8GMGYMs0cbHpcVoZTPWmm3jsXw== X-Google-Smtp-Source: ADFU+vtYCmQdzinR/X4HVv2e1fA66xpIh+DJ9q+KLmplPTod3qQodOWbJsvtyYzoNNVwTL7nNnPfAQ== X-Received: by 2002:a7b:c842:: with SMTP id c2mr799219wml.154.1585616642896; Mon, 30 Mar 2020 18:04:02 -0700 (PDT) Received: from cheddar.halon.org.uk (cheddar.halon.org.uk. [93.93.131.118]) by smtp.gmail.com with ESMTPSA id y7sm27040892wrq.54.2020.03.30.18.04.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 18:04:02 -0700 (PDT) Received: from bsmtp by cheddar.halon.org.uk with local-bsmtp (Exim 4.92) (envelope-from ) id 1jJ5Jx-0001Yw-P5; Tue, 31 Mar 2020 02:04:01 +0100 Received: from stemci01 by c30-smcintyre.einval.org with local (Exim 4.92) (envelope-from ) id 1jJ5Js-00016k-Lf; Tue, 31 Mar 2020 02:03:56 +0100 Date: Tue, 31 Mar 2020 02:03:56 +0100 From: Steve McIntyre To: Alexandre Torgue Cc: Frank Rowand , robh+dt@kernel.org, Masahiro Yamada , Michal Marek , david@gibson.dropbear.id.au, sjg@chromium.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, devicetree-compiler@vger.kernel.org, Ian Lepore Subject: Re: [RFC PATCH v2 0/4] Add device tree build information Message-ID: <20200331010347.GF4037@linaro.org> References: <20200221161418.20225-1-alexandre.torgue@st.com> <1b946fcf-47a9-012d-1b04-f4bbd2682607@gmail.com> <67d75f0c-7478-23b0-8619-746cf83cedb5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-attached: none User-Agent: Mutt/1.10.1 (2018-07-13) X-wibble: sender_address steve.mcintyre@linaro.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexandre, On Mon, Mar 02, 2020 at 01:55:55PM +0100, Alexandre Torgue wrote: >On 2/28/20 6:47 PM, Frank Rowand wrote: >> > This would require modifying every single main .dts file to get the build info >> > I would prefer the method that Ian and David came up with (sorry, no lore link, >> > it did not go to lkml). Extract from David's email: >> > >> > Date: Tue, 21 Jan 2020 13:05:25 +1100 >> > From: David Gibson >> > Subject: Re: [RFC PATCH 1/3] dtc: Add dtb build information option >> > >> > > Given that dts files are run through the C preprocessor before being >> > > fed to dtc, the build script could use the '-include' flag to force- >> > > include a fragment containing generated build info without any need to >> > > modify existing dts files. >> > >> > Uh... maybe. -include will essentially prepend the forced file, which >> > is a bit awkward for our purposes. It means that the prepended file >> > would need the /dts-v1/ tag, and we couldn't have it in the main files >> > which would be a bit confusing. I think it would also cause problems >> > with any /memreserve/ tags and means that the main tree could in >> > theory overwrite the build information which we don't necessarily >> > want. >> > >> > I guess we could build things the other way around: have the main .dts >> > file specified with -include and have the dts on the dtc commandline >> > be a fixed one with the build information. It'd be a little weird, >> > though. >> > >> > -Frank > >Yes. I try briefly this idea but I got issues with dts-v1 tag. I agree, it is >cleaner to not modify input dts file. I can rework int this way. Have you made any progress on this please? Cheers, -- Steve McIntyre steve.mcintyre@linaro.org Linaro.org | Open source software for ARM SoCs