From: Jules Irenge <jbi.octave@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: boqun.feng@gmail.com, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM)
Subject: [PATCH 5/7] btrfs: Add missing annotation for btrfs_lock_cluster()
Date: Tue, 31 Mar 2020 21:46:41 +0100 [thread overview]
Message-ID: <20200331204643.11262-6-jbi.octave@gmail.com> (raw)
In-Reply-To: <20200331204643.11262-1-jbi.octave@gmail.com>
Sparse reports a warning at btrfs_lock_cluster()
warning: context imbalance in btrfs_lock_cluster()
- wrong count
The root cause is the missing annotation at btrfs_lock_cluster()
Add the missing __acquires(&cluster->refill_lock) annotation.
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
fs/btrfs/extent-tree.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 0163fdd59f8f..9057a5ca6678 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -3395,6 +3395,7 @@ static struct btrfs_block_group *btrfs_lock_cluster(
struct btrfs_block_group *block_group,
struct btrfs_free_cluster *cluster,
int delalloc)
+ __acquires(&cluster->refill_lock)
{
struct btrfs_block_group *used_bg = NULL;
--
2.24.1
next prev parent reply other threads:[~2020-03-31 20:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/7>
2020-03-31 20:46 ` [PATCH 0/7] Lock warnings cleanup Jules Irenge
2020-03-31 20:46 ` [PATCH 1/7] fs: Add missing annotation for iput_final() Jules Irenge
2020-03-31 20:46 ` [PATCH 2/7] fsnotify: Add missing annotation for fsnotify_finish_user_wait() Jules Irenge
2020-04-01 9:24 ` Jan Kara
2020-04-03 16:15 ` Jules Irenge
2020-04-03 16:52 ` Jan Kara
2020-03-31 20:46 ` [PATCH 3/7] dax: Add missing annotation for wait_entry_unlocked() Jules Irenge
2020-04-01 10:01 ` Jan Kara
2020-04-01 16:04 ` Jules Irenge
2020-03-31 20:46 ` [PATCH 4/7] sysctl: Add missing annotation for start_unregistering() Jules Irenge
2020-04-02 16:06 ` Luis Chamberlain
2020-03-31 20:46 ` Jules Irenge [this message]
2020-04-01 15:57 ` [PATCH 5/7] btrfs: Add missing annotation for btrfs_lock_cluster() David Sterba
2020-03-31 20:46 ` [PATCH 6/7] btrfs: Add missing annotation for btrfs_tree_lock() Jules Irenge
2020-03-31 20:46 ` [PATCH 7/7] tty: serial_core: Add missing annotation for _unlock_and_check_sysrq() Jules Irenge
2020-04-16 13:58 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331204643.11262-6-jbi.octave@gmail.com \
--to=jbi.octave@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).