* [PATCH] proc: rename "catch" function argument
@ 2020-03-31 21:09 Alexey Dobriyan
2020-04-16 4:07 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2020-03-31 21:09 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, linux-fsdevel
"catch" is reserved keyword in C++, rename it to something
both gcc and g++ accept.
Rename "ign" for symmetry.
Signed-off-by: _Z6Alexeyv <adobriyan@gmail.com>
---
fs/proc/array.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -248,8 +248,8 @@ void render_sigset_t(struct seq_file *m, const char *header,
seq_putc(m, '\n');
}
-static void collect_sigign_sigcatch(struct task_struct *p, sigset_t *ign,
- sigset_t *catch)
+static void collect_sigign_sigcatch(struct task_struct *p, sigset_t *sigign,
+ sigset_t *sigcatch)
{
struct k_sigaction *k;
int i;
@@ -257,9 +257,9 @@ static void collect_sigign_sigcatch(struct task_struct *p, sigset_t *ign,
k = p->sighand->action;
for (i = 1; i <= _NSIG; ++i, ++k) {
if (k->sa.sa_handler == SIG_IGN)
- sigaddset(ign, i);
+ sigaddset(sigign, i);
else if (k->sa.sa_handler != SIG_DFL)
- sigaddset(catch, i);
+ sigaddset(sigcatch, i);
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] proc: rename "catch" function argument
2020-03-31 21:09 [PATCH] proc: rename "catch" function argument Alexey Dobriyan
@ 2020-04-16 4:07 ` Andrew Morton
2020-04-16 17:21 ` Alexey Dobriyan
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2020-04-16 4:07 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel, linux-fsdevel
On Wed, 1 Apr 2020 00:09:05 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> "catch" is reserved keyword in C++, rename it to something
> both gcc and g++ accept.
Why? Is someone compiling the kernel with g++?
> Rename "ign" for symmetry.
>
> Signed-off-by: _Z6Alexeyv <adobriyan@gmail.com>
Was this intentional?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] proc: rename "catch" function argument
2020-04-16 4:07 ` Andrew Morton
@ 2020-04-16 17:21 ` Alexey Dobriyan
2020-04-17 3:04 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2020-04-16 17:21 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, linux-fsdevel
On Wed, Apr 15, 2020 at 09:07:27PM -0700, Andrew Morton wrote:
> On Wed, 1 Apr 2020 00:09:05 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > "catch" is reserved keyword in C++, rename it to something
> > both gcc and g++ accept.
>
> Why? Is someone compiling the kernel with g++?
I do!
https://marc.info/?l=linux-acpi&m=158343373912366&w=4
> > Rename "ign" for symmetry.
> >
> > Signed-off-by: _Z6Alexeyv <adobriyan@gmail.com>
>
> Was this intentional?
In Russia, C++ mangles you! :^)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] proc: rename "catch" function argument
2020-04-16 17:21 ` Alexey Dobriyan
@ 2020-04-17 3:04 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2020-04-17 3:04 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel, linux-fsdevel
On Thu, 16 Apr 2020 20:21:55 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Wed, Apr 15, 2020 at 09:07:27PM -0700, Andrew Morton wrote:
> > On Wed, 1 Apr 2020 00:09:05 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > > "catch" is reserved keyword in C++, rename it to something
> > > both gcc and g++ accept.
> >
> > Why? Is someone compiling the kernel with g++?
>
> I do!
> https://marc.info/?l=linux-acpi&m=158343373912366&w=4
>
Lol. But why?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-17 3:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 21:09 [PATCH] proc: rename "catch" function argument Alexey Dobriyan
2020-04-16 4:07 ` Andrew Morton
2020-04-16 17:21 ` Alexey Dobriyan
2020-04-17 3:04 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).