From: Chen Zhou <chenzhou10@huawei.com>
To: <rmfrfs@gmail.com>, <johan@kernel.org>, <elder@kernel.org>,
<gregkh@linuxfoundation.org>
Cc: <chenzhou10@huawei.com>, <greybus-dev@lists.linaro.org>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH -next] staging: greybus: fix a missing-check bug in gb_lights_light_config()
Date: Wed, 1 Apr 2020 11:00:17 +0800 [thread overview]
Message-ID: <20200401030017.100274-1-chenzhou10@huawei.com> (raw)
In gb_lights_light_config(), 'light->name' is allocated by kstrndup().
It returns NULL when fails, add check for it.
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/staging/greybus/light.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index d6ba25f..d2672b6 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -1026,7 +1026,8 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id)
light->channels_count = conf.channel_count;
light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL);
-
+ if (!light->name)
+ return -ENOMEM;
light->channels = kcalloc(light->channels_count,
sizeof(struct gb_channel), GFP_KERNEL);
if (!light->channels)
--
2.7.4
next reply other threads:[~2020-04-01 2:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 3:00 Chen Zhou [this message]
2020-04-01 10:16 ` [PATCH -next] staging: greybus: fix a missing-check bug in gb_lights_light_config() Rui Miguel Silva
2020-04-02 12:22 ` Dan Carpenter
2020-04-02 13:16 ` Rui Miguel Silva
2020-04-02 14:22 ` Dan Carpenter
2020-04-02 16:04 ` Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401030017.100274-1-chenzhou10@huawei.com \
--to=chenzhou10@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmfrfs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).