From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F80C43331 for ; Wed, 1 Apr 2020 09:24:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D72FA20714 for ; Wed, 1 Apr 2020 09:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731743AbgDAJYg (ORCPT ); Wed, 1 Apr 2020 05:24:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:45164 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbgDAJYg (ORCPT ); Wed, 1 Apr 2020 05:24:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BCD2EAD7C; Wed, 1 Apr 2020 09:24:34 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id EF5BC1E11F4; Wed, 1 Apr 2020 11:24:33 +0200 (CEST) Date: Wed, 1 Apr 2020 11:24:33 +0200 From: Jan Kara To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Jan Kara , Amir Goldstein , "open list:FSNOTIFY: FILESYSTEM NOTIFICATION INFRASTRUCTURE" Subject: Re: [PATCH 2/7] fsnotify: Add missing annotation for fsnotify_finish_user_wait() Message-ID: <20200401092433.GA19466@quack2.suse.cz> References: <0/7> <20200331204643.11262-1-jbi.octave@gmail.com> <20200331204643.11262-3-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331204643.11262-3-jbi.octave@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 31-03-20 21:46:38, Jules Irenge wrote: > Sparse reports a warning at fsnotify_finish_user_wait() > > warning: context imbalance in fsnotify_finish_user_wait() > - wrong count at exit > > The root cause is the missing annotation at fsnotify_finish_user_wait() > Add the missing __acquires(&fsnotify_mark_srcu) annotation. > > Signed-off-by: Jules Irenge OK, but then fsnotify_prepare_user_wait() needs __releases annotation as well if we're going to be serious about sparse warnings in this code? Honza > --- > fs/notify/mark.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/notify/mark.c b/fs/notify/mark.c > index 1d96216dffd1..44fea637bb02 100644 > --- a/fs/notify/mark.c > +++ b/fs/notify/mark.c > @@ -350,6 +350,7 @@ bool fsnotify_prepare_user_wait(struct fsnotify_iter_info *iter_info) > } > > void fsnotify_finish_user_wait(struct fsnotify_iter_info *iter_info) > + __acquires(&fsnotify_mark_srcu) > { > int type; > > -- > 2.24.1 > -- Jan Kara SUSE Labs, CR