* [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines
@ 2020-03-27 16:58 Oscar Carter
2020-03-30 11:46 ` Quentin Deslandes
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Oscar Carter @ 2020-03-27 16:58 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman
Cc: Oscar Carter, Quentin Deslandes, Dan Carpenter, devel, linux-kernel
Define the EnCFG_BBType_MASK bit as an OR operation between two previous
defines instead of using the OR between two new BIT macros. Thus, the
code is more clear.
Fixes: a74081b44291 ("staging: vt6656: Use BIT() macro instead of hex value")
Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/staging/vt6656/mac.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h
index c532b27de37f..b01d9ee8677e 100644
--- a/drivers/staging/vt6656/mac.h
+++ b/drivers/staging/vt6656/mac.h
@@ -177,7 +177,7 @@
#define EnCFG_BBType_a 0x00
#define EnCFG_BBType_b BIT(0)
#define EnCFG_BBType_g BIT(1)
-#define EnCFG_BBType_MASK (BIT(0) | BIT(1))
+#define EnCFG_BBType_MASK (EnCFG_BBType_b | EnCFG_BBType_g)
#define EnCFG_ProtectMd BIT(5)
/* Bits in the EnhanceCFG_1 register */
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines
2020-03-27 16:58 [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines Oscar Carter
@ 2020-03-30 11:46 ` Quentin Deslandes
2020-03-30 12:27 ` Greg Kroah-Hartman
2020-03-31 10:29 ` Dan Carpenter
2 siblings, 0 replies; 5+ messages in thread
From: Quentin Deslandes @ 2020-03-30 11:46 UTC (permalink / raw)
To: Oscar Carter
Cc: Forest Bond, Greg Kroah-Hartman, Dan Carpenter, devel, linux-kernel
On 03/27/20 17:58:02, Oscar Carter wrote:
> Define the EnCFG_BBType_MASK bit as an OR operation between two previous
> defines instead of using the OR between two new BIT macros. Thus, the
> code is more clear.
>
> Fixes: a74081b44291 ("staging: vt6656: Use BIT() macro instead of hex value")
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/staging/vt6656/mac.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h
> index c532b27de37f..b01d9ee8677e 100644
> --- a/drivers/staging/vt6656/mac.h
> +++ b/drivers/staging/vt6656/mac.h
> @@ -177,7 +177,7 @@
> #define EnCFG_BBType_a 0x00
> #define EnCFG_BBType_b BIT(0)
> #define EnCFG_BBType_g BIT(1)
> -#define EnCFG_BBType_MASK (BIT(0) | BIT(1))
> +#define EnCFG_BBType_MASK (EnCFG_BBType_b | EnCFG_BBType_g)
> #define EnCFG_ProtectMd BIT(5)
>
> /* Bits in the EnhanceCFG_1 register */
> --
> 2.20.1
>
Reviewed-by: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
Thanks,
Quentin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines
2020-03-27 16:58 [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines Oscar Carter
2020-03-30 11:46 ` Quentin Deslandes
@ 2020-03-30 12:27 ` Greg Kroah-Hartman
2020-04-01 15:52 ` Oscar Carter
2020-03-31 10:29 ` Dan Carpenter
2 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-30 12:27 UTC (permalink / raw)
To: Oscar Carter; +Cc: Forest Bond, devel, linux-kernel, Dan Carpenter
On Fri, Mar 27, 2020 at 05:58:02PM +0100, Oscar Carter wrote:
> Define the EnCFG_BBType_MASK bit as an OR operation between two previous
> defines instead of using the OR between two new BIT macros. Thus, the
> code is more clear.
>
> Fixes: a74081b44291 ("staging: vt6656: Use BIT() macro instead of hex value")
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/staging/vt6656/mac.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h
> index c532b27de37f..b01d9ee8677e 100644
> --- a/drivers/staging/vt6656/mac.h
> +++ b/drivers/staging/vt6656/mac.h
> @@ -177,7 +177,7 @@
> #define EnCFG_BBType_a 0x00
> #define EnCFG_BBType_b BIT(0)
> #define EnCFG_BBType_g BIT(1)
> -#define EnCFG_BBType_MASK (BIT(0) | BIT(1))
> +#define EnCFG_BBType_MASK (EnCFG_BBType_b | EnCFG_BBType_g)
This does not "fix" anything, like your "Fixes:" tag implies. It just
cleans up the code some more. Only use Fixes: if it actually fixes a
problem introduced by a previous patch.
Can you remove that line and resend?
thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines
2020-03-27 16:58 [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines Oscar Carter
2020-03-30 11:46 ` Quentin Deslandes
2020-03-30 12:27 ` Greg Kroah-Hartman
@ 2020-03-31 10:29 ` Dan Carpenter
2 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2020-03-31 10:29 UTC (permalink / raw)
To: Oscar Carter
Cc: Forest Bond, Greg Kroah-Hartman, Quentin Deslandes, devel, linux-kernel
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines
2020-03-30 12:27 ` Greg Kroah-Hartman
@ 2020-04-01 15:52 ` Oscar Carter
0 siblings, 0 replies; 5+ messages in thread
From: Oscar Carter @ 2020-04-01 15:52 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Oscar Carter, Forest Bond, devel, linux-kernel, Dan Carpenter
On Mon, Mar 30, 2020 at 02:27:14PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Mar 27, 2020 at 05:58:02PM +0100, Oscar Carter wrote:
> > Define the EnCFG_BBType_MASK bit as an OR operation between two previous
> > defines instead of using the OR between two new BIT macros. Thus, the
> > code is more clear.
> >
> > Fixes: a74081b44291 ("staging: vt6656: Use BIT() macro instead of hex value")
> > Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > drivers/staging/vt6656/mac.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h
> > index c532b27de37f..b01d9ee8677e 100644
> > --- a/drivers/staging/vt6656/mac.h
> > +++ b/drivers/staging/vt6656/mac.h
> > @@ -177,7 +177,7 @@
> > #define EnCFG_BBType_a 0x00
> > #define EnCFG_BBType_b BIT(0)
> > #define EnCFG_BBType_g BIT(1)
> > -#define EnCFG_BBType_MASK (BIT(0) | BIT(1))
> > +#define EnCFG_BBType_MASK (EnCFG_BBType_b | EnCFG_BBType_g)
>
> This does not "fix" anything, like your "Fixes:" tag implies. It just
> cleans up the code some more. Only use Fixes: if it actually fixes a
> problem introduced by a previous patch.
>
Ok, thanks for the explanation.
> Can you remove that line and resend?
>
Yes, I will remove that line, I will create a new version of this patch and I
will resend it.
> thanks.
>
> greg k-h
Thanks,
oscar carter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-01 15:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-27 16:58 [PATCH] staging: vt6656: Define EnCFG_BBType_MASK as OR between previous defines Oscar Carter
2020-03-30 11:46 ` Quentin Deslandes
2020-03-30 12:27 ` Greg Kroah-Hartman
2020-04-01 15:52 ` Oscar Carter
2020-03-31 10:29 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).