From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6649DC2D0F2 for ; Wed, 1 Apr 2020 16:23:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AEF6215A4 for ; Wed, 1 Apr 2020 16:23:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585758222; bh=nhJQxQCFLz20+3m0GlqbdNdv+16PiSrAntecgskSFgI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Jyn6m6ZZClHCwRCjZbsRBfgHIvXw9BJlwpDZVQ/dD9K3Wac1Dp9FjJJenMsks4z5C XhTPsfPUSAf9RF3f1p7ndsCHuue+ziraz8qdlXKxNsHKstw6aTkC0FGtV1wcTYODIM a5kAKHQBXMXwCcA5sVLJnOvSYLa6awX4YHev00Ro= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387619AbgDAQXl (ORCPT ); Wed, 1 Apr 2020 12:23:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:46982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387610AbgDAQXh (ORCPT ); Wed, 1 Apr 2020 12:23:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F2412137B; Wed, 1 Apr 2020 16:23:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585758217; bh=nhJQxQCFLz20+3m0GlqbdNdv+16PiSrAntecgskSFgI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iZjFAJGbt/vM6DQmWGuN088CzD4y+Vidrq8VZg6QGZIjBafpHHfLdv0LiVwtU6vo5 2AI7VR86HVd6P2rAYezyWCG7PhJAJ1KOf2knKDiGJRd93XTsrPxyAiN3Qb/fBEgG2r lxj2i5EJMKDo+VG81FXyZ8k4t/HdKeNXwC0T2A0s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, yangerkun , Oliver Hartkopp , "David S. Miller" Subject: [PATCH 4.19 020/116] slcan: not call free_netdev before rtnl_unlock in slcan_open Date: Wed, 1 Apr 2020 18:16:36 +0200 Message-Id: <20200401161544.816097128@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161542.669484650@linuxfoundation.org> References: <20200401161542.669484650@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Hartkopp [ Upstream commit 2091a3d42b4f339eaeed11228e0cbe9d4f92f558 ] As the description before netdev_run_todo, we cannot call free_netdev before rtnl_unlock, fix it by reorder the code. This patch is a 1:1 copy of upstream slip.c commit f596c87005f7 ("slip: not call free_netdev before rtnl_unlock in slip_open"). Reported-by: yangerkun Signed-off-by: Oliver Hartkopp Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/slcan.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -621,7 +621,10 @@ err_free_chan: tty->disc_data = NULL; clear_bit(SLF_INUSE, &sl->flags); slc_free_netdev(sl->dev); + /* do not call free_netdev before rtnl_unlock */ + rtnl_unlock(); free_netdev(sl->dev); + return err; err_exit: rtnl_unlock();