From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB296C43331 for ; Wed, 1 Apr 2020 16:41:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E4FF20BED for ; Wed, 1 Apr 2020 16:41:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759286; bh=WRBUD46qixzrv7/fKXx1wY16VvMfeiD7Ux85sux5KAU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fDj+dtreKsYO5GER13Zqk6OEPhppubfudagGyp+9qaP47CWyj2qFYLsmb6fmt06as yiZb7fwVtztdUG3Csmsy6Tkf10aK+tBwqKXm86BmuIL4Czar72I0qvhdRg6G8AgZoJ Px1IkTAHWy9HjD2QA22I+kq7AhpI3l0e87JwZqrY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389156AbgDAQlZ (ORCPT ); Wed, 1 Apr 2020 12:41:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:41678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389238AbgDAQlW (ORCPT ); Wed, 1 Apr 2020 12:41:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03E732063A; Wed, 1 Apr 2020 16:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759281; bh=WRBUD46qixzrv7/fKXx1wY16VvMfeiD7Ux85sux5KAU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G5wFvIkWo9GOdoULhmENWZtVoCbWlBEUGpoktyzE1Q/Uh2BPmElzfpFs5+4Qwhdrg V+QxFp/h++ZfqEpWY5rlluWkU5XndyzLbqt3T1yX4qKnofXmTi4ItHt9EGbQZ+ABQA 06M0GmJ927DeCqL5SDUsjbDyhqRhdOK198CB5sX8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kirk Reiser , Janina Sajka , Alexandr Epaneshnikov , Gregory Nowak , deedra waters , Samuel Thibault , Michael Taboada Subject: [PATCH 4.14 030/148] staging/speakup: fix get_word non-space look-ahead Date: Wed, 1 Apr 2020 18:17:02 +0200 Message-Id: <20200401161555.435323323@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Thibault commit 9d32c0cde4e2d1343dfb88a67b2ec6397705b32b upstream. get_char was erroneously given the address of the pointer to the text instead of the address of the text, thus leading to random crashes when the user requests speaking a word while the current position is on a space character and say_word_ctl is not enabled. Reported-on: https://github.com/bytefire/speakup/issues/1 Reported-by: Kirk Reiser Reported-by: Janina Sajka Reported-by: Alexandr Epaneshnikov Reported-by: Gregory Nowak Reported-by: deedra waters Signed-off-by: Samuel Thibault Tested-by: Alexandr Epaneshnikov Tested-by: Gregory Nowak Tested-by: Michael Taboada Cc: stable Link: https://lore.kernel.org/r/20200306003047.thijtmqrnayd3dmw@function Signed-off-by: Greg Kroah-Hartman --- drivers/staging/speakup/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/speakup/main.c +++ b/drivers/staging/speakup/main.c @@ -567,7 +567,7 @@ static u_long get_word(struct vc_data *v return 0; } else if (tmpx < vc->vc_cols - 2 && (ch == SPACE || ch == 0 || (ch < 0x100 && IS_WDLM(ch))) && - get_char(vc, (u_short *)&tmp_pos + 1, &temp) > SPACE) { + get_char(vc, (u_short *)tmp_pos + 1, &temp) > SPACE) { tmp_pos += 2; tmpx++; } else