From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4E84C43331 for ; Wed, 1 Apr 2020 16:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 847D620714 for ; Wed, 1 Apr 2020 16:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759467; bh=D7cfcTWcDPuK94XUyfReD3ZLUSUdLERf/5iHNX5SLsY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HhbGK5rsr2jxJIujEhaBRUOMvTDE1fAwQnJvhNZwspmN4HIYs/C7qRNQKkTD5Xn1o MUcytF1jj49Yu4HNGDk5sJGyLPR3OxCcZw9Ki3PlRmXEQdsYZhYUEXGD3XVuQYjzDS E8jMs30K7eoi0Qgm02DUGv0cun+warm1Qf5qa33E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389570AbgDAQo0 (ORCPT ); Wed, 1 Apr 2020 12:44:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:45368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389717AbgDAQoW (ORCPT ); Wed, 1 Apr 2020 12:44:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E50B720714; Wed, 1 Apr 2020 16:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759462; bh=D7cfcTWcDPuK94XUyfReD3ZLUSUdLERf/5iHNX5SLsY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TRNxPysHVCmpF4m6e+aSssIdb7z0kJxpRlVaLySeb4jBPznig/pQsSiJJ6TKAfH/h rAVgEUXXzHFWRpYpMnlAFvYaT2a4d1XsCKo91D+HP+9UqCCM7T0aDjHQ9LtKd0qdGN Egd0NRxbMhxmGok351OhpRG+cwZX5siFm+A+yXck= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chuhong Yuan , Wolfram Sang , stable@kernel.org Subject: [PATCH 4.14 088/148] i2c: hix5hd2: add missed clk_disable_unprepare in remove Date: Wed, 1 Apr 2020 18:18:00 +0200 Message-Id: <20200401161601.471986906@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan commit e1b9f99ff8c40bba6e59de9ad4a659447b1e4112 upstream. The driver forgets to disable and unprepare clk when remove. Add a call to clk_disable_unprepare to fix it. Signed-off-by: Chuhong Yuan Signed-off-by: Wolfram Sang Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-hix5hd2.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/i2c/busses/i2c-hix5hd2.c +++ b/drivers/i2c/busses/i2c-hix5hd2.c @@ -498,6 +498,7 @@ static int hix5hd2_i2c_remove(struct pla i2c_del_adapter(&priv->adap); pm_runtime_disable(priv->dev); pm_runtime_set_suspended(priv->dev); + clk_disable_unprepare(priv->clk); return 0; }