From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
David Hildenbrand <david@redhat.com>,
Shile Zhang <shile.zhang@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mm: fix tick timer stall during deferred page init
Date: Wed, 1 Apr 2020 13:13:31 -0400 [thread overview]
Message-ID: <20200401171331.26v6th25ezhixwpt@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <CA+CK2bCKxok9Ho2NJd0kWR=YCi+eQqyfv6fg1Je3Lmov9PqzwQ@mail.gmail.com>
On Wed, Apr 01, 2020 at 12:51:56PM -0400, Pavel Tatashin wrote:
> > > I do not remember seeing any real failures, this was a theoretical
> > > window. So, we could potentially simply remove these locks until we
> > > see a real boot failure in some interrupt thread. The allocation has
> > > to be rather large as well.
> >
> > Yes please! We are really great at over complicating and over
> > engineering stuff based on theoretical issues and build on top of that
> > and make the code even more complex because nobody dares to re-evaluate
> > and so on.
>
> I will submit a patch (or revert) whichever is cleaner.
I had thought people would be concerned about that window. I believe the quote
from the time it was being discussed was "rare failures suck." They very much
do :) but in this case I think any failure would be relatively easy to
diagnose.
So great, simpler is always better, and I'll wait for what you send, Pasha.
Alternatively, if you won't be able to get to it for a while, I can write it
up, having thoroughly paged all this in over the past week.
prev parent reply other threads:[~2020-04-01 17:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 12:38 [PATCH v3] mm: fix tick timer stall during deferred page init Shile Zhang
2020-03-11 17:45 ` Pavel Tatashin
2020-03-11 20:16 ` Kirill Tkhai
2020-03-11 20:25 ` Pavel Tatashin
2020-03-19 19:05 ` Daniel Jordan
2020-03-26 18:58 ` Daniel Jordan
2020-03-26 19:36 ` Pavel Tatashin
2020-03-27 4:39 ` Shile Zhang
2020-03-28 0:17 ` Daniel Jordan
2020-04-01 14:26 ` David Hildenbrand
2020-04-01 15:42 ` Michal Hocko
2020-04-01 15:50 ` David Hildenbrand
2020-04-01 16:00 ` Michal Hocko
2020-04-01 16:09 ` Daniel Jordan
2020-04-01 16:12 ` Michal Hocko
2020-04-01 16:15 ` David Hildenbrand
2020-04-01 16:18 ` Daniel Jordan
2020-04-01 16:26 ` Michal Hocko
2020-04-01 16:41 ` Pavel Tatashin
2020-04-01 16:46 ` Michal Hocko
2020-04-01 16:51 ` Pavel Tatashin
2020-04-01 17:13 ` Daniel Jordan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200401171331.26v6th25ezhixwpt@ca-dmjordan1.us.oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=shile.zhang@linux.alibaba.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).