From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: ayush.sawal@chelsio.com, vinay.yadav@chelsio.com,
rohitm@chelsio.com, herbert@gondor.apana.org.au,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net] crypto: chtls - Fix build error without IPV6
Date: Thu, 02 Apr 2020 06:54:46 -0700 (PDT) [thread overview]
Message-ID: <20200402.065446.2295152097236024797.davem@davemloft.net> (raw)
In-Reply-To: <20200402014323.36492-1-yuehaibing@huawei.com>
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 2 Apr 2020 09:43:23 +0800
> If IPV6 is not set, build fails:
>
> drivers/crypto/chelsio/chcr_ktls.c: In function ‘chcr_ktls_act_open_req6’:
> ./include/net/sock.h:380:37: error: ‘struct sock_common’ has no member named ‘skc_v6_rcv_saddr’; did you mean ‘skc_rcv_saddr’?
> #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
> ^
> drivers/crypto/chelsio/chcr_ktls.c:258:37: note: in expansion of macro ‘sk_v6_rcv_saddr’
> cpl->local_ip_hi = *(__be64 *)&sk->sk_v6_rcv_saddr.in6_u.u6_addr8[0];
> ^~~~~~~~~~~~~~~
>
> Add IPV6 dependency to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 62370a4f346d ("cxgb4/chcr: Add ipv6 support and statistics")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This is a hard hammer, and I think proper CPP testing should be added to the
driver code instead.
prev parent reply other threads:[~2020-04-02 13:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 1:43 [PATCH net] crypto: chtls - Fix build error without IPV6 YueHaibing
2020-04-02 13:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402.065446.2295152097236024797.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ayush.sawal@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rohitm@chelsio.com \
--cc=vinay.yadav@chelsio.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).