From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, jgg@mellanox.com,
maxime.coquelin@redhat.com, cunming.liang@intel.com,
zhihong.wang@intel.com, rob.miller@broadcom.com,
xiao.w.wang@intel.com, lingshan.zhu@intel.com,
eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com,
kevin.tian@intel.com, stefanha@redhat.com, rdunlap@infradead.org,
hch@infradead.org, aadam@redhat.com, jiri@mellanox.com,
shahafs@mellanox.com, hanand@xilinx.com, mhabets@solarflare.com,
gdawar@xilinx.com, saugatm@xilinx.com, vmireyno@marvell.com,
zhangweining@ruijie.com.cn
Subject: Re: [PATCH V9 1/9] vhost: refine vhost and vringh kconfig
Date: Thu, 2 Apr 2020 10:38:39 -0400 [thread overview]
Message-ID: <20200402103813-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <279ed96c-5331-9da6-f9c1-b49e87d49c31@redhat.com>
On Thu, Apr 02, 2020 at 10:23:59PM +0800, Jason Wang wrote:
>
> On 2020/4/2 下午10:03, Michael S. Tsirkin wrote:
> > On Thu, Apr 02, 2020 at 11:22:57AM +0800, Jason Wang wrote:
> > > On 2020/4/2 上午12:08, Michael S. Tsirkin wrote:
> > > > On Wed, Apr 01, 2020 at 10:29:32PM +0800, Jason Wang wrote:
> > > > > >From 9b3a5d23b8bf6b0a11e65e688335d782f8e6aa5c Mon Sep 17 00:00:00 2001
> > > > > From: Jason Wang <jasowang@redhat.com>
> > > > > Date: Wed, 1 Apr 2020 22:17:27 +0800
> > > > > Subject: [PATCH] vhost: let CONFIG_VHOST to be selected by drivers
> > > > >
> > > > > The defconfig on some archs enable vhost_net or vhost_vsock by
> > > > > default. So instead of adding CONFIG_VHOST=m to all of those files,
> > > > > simply letting CONFIG_VHOST to be selected by all of the vhost
> > > > > drivers. This fixes the build on the archs with CONFIG_VHOST_NET=m in
> > > > > their defconfig.
> > > > >
> > > > > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > > > > ---
> > > > > drivers/vhost/Kconfig | 15 +++++++++++----
> > > > > 1 file changed, 11 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
> > > > > index 2523a1d4290a..362b832f5338 100644
> > > > > --- a/drivers/vhost/Kconfig
> > > > > +++ b/drivers/vhost/Kconfig
> > > > > @@ -11,19 +11,23 @@ config VHOST_RING
> > > > > This option is selected by any driver which needs to access
> > > > > the host side of a virtio ring.
> > > > > -menuconfig VHOST
> > > > > - tristate "Host kernel accelerator for virtio (VHOST)"
> > > > > - depends on EVENTFD
> > > > > +config VHOST
> > > > > + tristate
> > > > > select VHOST_IOTLB
> > > > > help
> > > > > This option is selected by any driver which needs to access
> > > > > the core of vhost.
> > > > > -if VHOST
> > > > > +menuconfig VHOST_MENU
> > > > > + bool "VHOST drivers"
> > > > > + default y
> > > > > +
> > > > > +if VHOST_MENU
> > > > > config VHOST_NET
> > > > > tristate "Host kernel accelerator for virtio net"
> > > > > depends on NET && EVENTFD && (TUN || !TUN) && (TAP || !TAP)
> > > > > + select VHOST
> > > > > ---help---
> > > > > This kernel module can be loaded in host kernel to accelerate
> > > > > guest networking with virtio_net. Not to be confused with virtio_net
> > > > > @@ -35,6 +39,7 @@ config VHOST_NET
> > > > > config VHOST_SCSI
> > > > > tristate "VHOST_SCSI TCM fabric driver"
> > > > > depends on TARGET_CORE && EVENTFD
> > > > > + select VHOST
> > > > > default n
> > > > > ---help---
> > > > > Say M here to enable the vhost_scsi TCM fabric module
> > > > > @@ -43,6 +48,7 @@ config VHOST_SCSI
> > > > > config VHOST_VSOCK
> > > > > tristate "vhost virtio-vsock driver"
> > > > > depends on VSOCKETS && EVENTFD
> > > > > + select VHOST
> > > > > select VIRTIO_VSOCKETS_COMMON
> > > > > default n
> > > > > ---help---
> > > > > @@ -56,6 +62,7 @@ config VHOST_VSOCK
> > > > > config VHOST_VDPA
> > > > > tristate "Vhost driver for vDPA-based backend"
> > > > > depends on EVENTFD
> > > > > + select VHOST
> > >
> > > This part is not squashed.
> > >
> > >
> > > > > select VDPA
> > > > > help
> > > > > This kernel module can be loaded in host kernel to accelerate
> > > > OK so I squashed this into the original buggy patch.
> > > > Could you please play with vhost branch of my tree on various
> > > > arches? If it looks ok to you let me know I'll push
> > > > this to next.
> > >
> > > With the above part squashed. I've tested all the archs whose defconfig have
> > > VHOST_NET or VHOST_VSOCK enabled.
> > >
> > > All looks fine.
> > >
> > > Thanks
> >
> > I'm a bit confused. So is the next tag in my tree ok now?
>
>
> Still need to select CONFIG_VHOST for CONFIG_VHOST_VDPA. Others are ok.
>
> Thanks
Oh like this then?
diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig
index bdd270fede26..cb6b17323eb2 100644
--- a/drivers/vhost/Kconfig
+++ b/drivers/vhost/Kconfig
@@ -61,6 +63,7 @@ config VHOST_VSOCK
config VHOST_VDPA
tristate "Vhost driver for vDPA-based backend"
depends on EVENTFD
+ select VHOST
select VDPA
help
This kernel module can be loaded in host kernel to accelerate
next prev parent reply other threads:[~2020-04-02 14:38 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 14:01 [PATCH V9 0/9] vDPA support Jason Wang
2020-03-26 14:01 ` [PATCH V9 1/9] vhost: refine vhost and vringh kconfig Jason Wang
2020-04-01 11:21 ` Christian Borntraeger
2020-04-01 12:50 ` Jason Wang
2020-04-01 12:56 ` Christian Borntraeger
2020-04-01 13:02 ` Christian Borntraeger
2020-04-01 14:01 ` Michael S. Tsirkin
2020-04-01 14:13 ` Jason Wang
2020-04-01 14:18 ` Michael S. Tsirkin
2020-04-01 14:36 ` Jason Wang
2020-04-01 14:27 ` Michael S. Tsirkin
2020-04-01 14:50 ` Jason Wang
2020-04-01 15:57 ` Michael S. Tsirkin
2020-04-01 18:53 ` Christian Borntraeger
2020-04-01 13:22 ` Michael S. Tsirkin
2020-04-01 14:08 ` Jason Wang
2020-04-01 14:13 ` Michael S. Tsirkin
2020-04-01 14:29 ` Jason Wang
2020-04-01 14:35 ` Michael S. Tsirkin
2020-04-01 14:39 ` Jason Wang
2020-04-01 14:39 ` Michael S. Tsirkin
2020-04-01 14:43 ` Jason Wang
2020-04-01 16:05 ` Michael S. Tsirkin
2020-04-01 16:08 ` Michael S. Tsirkin
2020-04-02 3:22 ` Jason Wang
2020-04-02 14:03 ` Michael S. Tsirkin
2020-04-02 14:23 ` Jason Wang
2020-04-02 14:38 ` Michael S. Tsirkin [this message]
2020-04-02 14:56 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 2/9] vhost: allow per device message handler Jason Wang
2020-03-26 14:01 ` [PATCH V9 3/9] vhost: factor out IOTLB Jason Wang
2020-03-26 14:01 ` [PATCH V9 4/9] vringh: IOTLB support Jason Wang
2020-03-26 14:01 ` [PATCH V9 5/9] vDPA: introduce vDPA bus Jason Wang
2020-03-26 14:01 ` [PATCH V9 6/9] virtio: introduce a vDPA based transport Jason Wang
2020-03-26 14:01 ` [PATCH V9 7/9] vhost: introduce vDPA-based backend Jason Wang
2021-11-01 14:11 ` Jason Gunthorpe
2021-11-02 3:52 ` Jason Wang
2021-11-02 15:56 ` Jason Gunthorpe
2021-11-03 7:34 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 8/9] vdpasim: vDPA device simulator Jason Wang
2020-04-10 7:45 ` Geert Uytterhoeven
2020-04-10 8:23 ` Jason Wang
2020-03-26 14:01 ` [PATCH V9 9/9] virtio: Intel IFC VF driver for VDPA Jason Wang
2020-04-09 10:41 ` Arnd Bergmann
2020-04-09 12:43 ` Jason Wang
2020-04-09 12:49 ` Zhu, Lingshan
2020-04-09 20:25 ` Michael S. Tsirkin
2020-04-10 3:15 ` Zhu, Lingshan
2020-03-29 11:07 ` [PATCH V9 0/9] vDPA support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402103813-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aadam@redhat.com \
--cc=cunming.liang@intel.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jgg@mellanox.com \
--cc=jiri@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mhabets@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=rdunlap@infradead.org \
--cc=rob.miller@broadcom.com \
--cc=saugatm@xilinx.com \
--cc=shahafs@mellanox.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vmireyno@marvell.com \
--cc=xiao.w.wang@intel.com \
--cc=zhangweining@ruijie.com.cn \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).