From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85E8C43331 for ; Thu, 2 Apr 2020 18:31:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE5702078E for ; Thu, 2 Apr 2020 18:31:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jHiZcgy/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389576AbgDBSbL (ORCPT ); Thu, 2 Apr 2020 14:31:11 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:39328 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732330AbgDBSbL (ORCPT ); Thu, 2 Apr 2020 14:31:11 -0400 Received: by mail-pj1-f65.google.com with SMTP id z3so1832500pjr.4 for ; Thu, 02 Apr 2020 11:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kZGuI29ZXRMYLlFqPcGnn2ZEpsArv5KS+IfYEt8rJDE=; b=jHiZcgy/2u30npHwDtjgCz/jYSsE83IkRbOXE5Io/gv1QNhpRoRnWFd6XA0HVEyK6J a9CMWCnII9zcMVEj+hLYILZ8NPkiM8WtOYpQdjzOVibuUBfbzWBNLJVl33/ivEjarjBV +WHBYHaX9sjAsbujCfwN1A8OE3jwzbZ5I5H9A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kZGuI29ZXRMYLlFqPcGnn2ZEpsArv5KS+IfYEt8rJDE=; b=YaURk94eKTrA2N1db9J76pw+wo8O4Ykjw5EomjySY1U2cGCEB536kXtoYuuOwD+9tc Nk+Cc8O1ptAPbyMQHxmJH4EGImRjUQG4IHXF/Oj13wRY1+YZ73qqWxazDbkXkacIutKm juoCN+EvjsQ1oJcutlJDMeZhmZPsCw5RJUrOVTXbif3OhNpRWPCuzrbnnWXWcMTwJLBY LYe+eRQx3fUgfDCVHmxJObXQvAqaEaQ8HKr8xTT3XQi4BzKptahvibzPIuJ0mZKcIEwo gGmMsmu+1fSgnIiwFOere2LIY6RuSeDYt1e9G7gjq+tA65kqVX4R8q4Ckabuj8Evlaz1 RaDg== X-Gm-Message-State: AGi0PubIg35MVuDf9EfqxteIMbLjvoPGYlwzq+vffoaoGlDGIRICaUY7 U90PT48qE1ZYyYrsKf/7b0GWvKTKs+8= X-Google-Smtp-Source: APiQypKbcVQftrWqKopgwEhOoaCPTB+Z5eo9TF6NM+bJ7aXLaXln6MGlsZMszWvro18nAm0OXNzTJg== X-Received: by 2002:a17:90b:46d0:: with SMTP id jx16mr5148235pjb.155.1585852270186; Thu, 02 Apr 2020 11:31:10 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z15sm4267487pfg.152.2020.04.02.11.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 11:31:09 -0700 (PDT) Date: Thu, 2 Apr 2020 11:31:08 -0700 From: Kees Cook To: Nick Desaulniers Cc: Masahiro Yamada , Michal Marek , Thomas Gleixner , Linux Kbuild mailing list , clang-built-linux , Linux Kernel Mailing List , Sandeep Patil Subject: Re: [PATCH] kbuild: mkcompile_h: Include $LD version in /proc/version Message-ID: <202004021129.F688E2D@keescook> References: <202004020117.6E434C035@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 02, 2020 at 11:22:02AM -0700, Nick Desaulniers wrote: > With Kees patch + Masahiro's diff applied: > $ cat /proc/version > Linux version 5.6.0-rc7-next-20200330+ (ndesaulniers@ scrubbed>) (clang version 11.0.0 (git@github.com:llvm/llvm-project.git > 6d71daed03ced011cd25f4e4f4122a368fdc757d), LLD 11.0.0 > (git@github.com:llvm/llvm-project.git > 6d71daed03ced011cd25f4e4f4122a368fdc757d)) #167 SMP Thu Apr 2 11:17:36 > PDT 2020 > > Reviewed-by: Nick Desaulniers > Tested-by: Nick Desaulniers Awesome! Thanks for testing. :) > We could actually use this in Android for a VTS test I've, uh, been > meaning to write. Also, LOL at scrubbing the "compatible with" part, > reminds me of user agent strings in the browser, which are god awful. Heh, yeah. That's there because (actually, I think _you_ told me this when I asked during the ClangBuiltLinux summit) other tools scanned the LD version string for the binutils-specific bits. For this, since it's newly added to the kernel /proc/version, nothing is already expecting to find an LD string, and it looked super weird in there if I left it as-is. Hence, scrub! -Kees -- Kees Cook