From: Fangrui Song <maskray@google.com>
To: 'Nick Desaulniers' via Clang Built Linux
<clang-built-linux@googlegroups.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <natechancellor@gmail.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sandeep Patil <sspatil@google.com>
Subject: Re: [PATCH v2] Makefile.llvm: simplify LLVM build
Date: Thu, 2 Apr 2020 09:39:57 -0700 [thread overview]
Message-ID: <20200402163957.lqgr3tpc4z7ish5e@google.com> (raw)
In-Reply-To: <CAKwvOdnYXXcfxWT6bOZXCX9-ac8tb=p2J53W+T-_gOfUu9vvSg@mail.gmail.com>
On 2020-04-01, 'Nick Desaulniers' via Clang Built Linux wrote:
>On Tue, Mar 31, 2020 at 11:11 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>>
>> On Wed, Apr 1, 2020 at 3:39 AM Nick Desaulniers <ndesaulniers@google.com> wrote:
>> >
>> > On Mon, Mar 30, 2020 at 11:25 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>> > >
>> > > Having both LLVM_DIR and LLVM_SUFFIX seems verbose.
>> >
>> > I agree, so maybe just LLVM=y, and we can support both non-standard
>> > locations and debian suffixes via modifications to PATH.
>>
>>
>>
>> OK, so we will start with the boolean switch 'LLVM'.
>>
>> People can use PATH to cope with directory path and suffixes.
>
>Sounds good, we will modify our CI to use PATH modifications rather
>than suffixes. We can even do that before such a patch to Makefile
>exists.
The proposed LLVM=1 + PATH scheme looks good to me.
There seems to be one issue.
OBJSIZE=llvm-objsize added in
commit fcf1b6a35c16ac500fa908a4022238e5d666eabf "Documentation/llvm: add documentation on building w/ Clang/LLVM"
is wrong.
The tool is named llvm-size. OBJSIZE is only used once:
arch/s390/scripts/Makefile.chkbss
14: if ! $(OBJSIZE) --common $< | $(AWK) 'END { if ($$3) exit 1 }'; then \
next prev parent reply other threads:[~2020-04-02 16:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200317202404.GA20746@ubuntu-m2-xlarge-x86>
2020-03-17 21:55 ` [PATCH v2] Makefile.llvm: simplify LLVM build Nick Desaulniers
2020-03-27 19:51 ` Nick Desaulniers
2020-03-27 22:42 ` Nathan Chancellor
2020-03-28 4:54 ` Masahiro Yamada
2020-03-29 1:56 ` Masahiro Yamada
2020-03-30 18:58 ` Nick Desaulniers
2020-03-30 19:03 ` Nathan Chancellor
2020-03-31 6:24 ` Masahiro Yamada
2020-03-31 18:39 ` Nick Desaulniers
2020-03-31 19:35 ` Nathan Chancellor
2020-03-31 19:40 ` Nick Desaulniers
2020-04-01 6:10 ` Masahiro Yamada
2020-04-01 17:48 ` Nick Desaulniers
2020-04-02 16:39 ` Fangrui Song [this message]
2020-04-02 16:54 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402163957.lqgr3tpc4z7ish5e@google.com \
--to=maskray@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=natechancellor@gmail.com \
--cc=sspatil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).