From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46607C43331 for ; Thu, 2 Apr 2020 23:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16C3320787 for ; Thu, 2 Apr 2020 23:08:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390145AbgDBXIo (ORCPT ); Thu, 2 Apr 2020 19:08:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:56734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732600AbgDBXIo (ORCPT ); Thu, 2 Apr 2020 19:08:44 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF1092073B; Thu, 2 Apr 2020 23:08:41 +0000 (UTC) Date: Thu, 2 Apr 2020 19:08:39 -0400 From: Steven Rostedt To: Nadav Amit Cc: Thomas Gleixner , Sean Christopherson , x86 , "Kenneth R . Crudup" , Paolo Bonzini , Fenghua Yu , Xiaoyao Li , Thomas Hellstrom , Tony Luck , Peter Zijlstra , Jessica Yu , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , kvm , LKML , Doug Covelli Subject: Re: [PATCH 3/3] KVM: VMX: Extend VMX's #AC interceptor to handle split lock #AC in guest Message-ID: <20200402190839.00315012@gandalf.local.home> In-Reply-To: <08D90BEB-89F6-4D94-8C2E-A21E43646938@vmware.com> References: <20200402124205.334622628@linutronix.de> <20200402155554.27705-1-sean.j.christopherson@intel.com> <20200402155554.27705-4-sean.j.christopherson@intel.com> <87sghln6tr.fsf@nanos.tec.linutronix.de> <20200402174023.GI13879@linux.intel.com> <87h7y1mz2s.fsf@nanos.tec.linutronix.de> <20200402205109.GM13879@linux.intel.com> <87zhbtle15.fsf@nanos.tec.linutronix.de> <08D90BEB-89F6-4D94-8C2E-A21E43646938@vmware.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Apr 2020 22:40:03 +0000 Nadav Amit wrote: > > On Apr 2, 2020, at 3:27 PM, Thomas Gleixner wrote: > > > > As I just verified, it's possible to load the vmware module parallel > > to the KVM/VMX one. > > > > So either we deal with it in some way or just decide that SLD and HV > > modules which do not have the MOD_INFO(sld_safe) magic cannot be loaded > > when SLD is enabled on the host. I'm fine with the latter :) > > > > What a mess. > > [ +Doug ] > > Just to communicate the information that was given to me: we do intend to > fix the SLD issue in VMware and if needed to release a minor version that > addresses it. Having said that, there are other hypervisors, such as > virtualbox or jailhouse, which would have a similar issue. If we go the approach of not letting VM modules load if it doesn't have the sld_safe flag set, how is this different than a VM module not loading due to kabi breakage? If we prevent it from loading (and keeping from having to go into this inconsistent state that Thomas described), it would encourage people to get the latest modules, and the maintainers of said modules motivation to update them. -- Steve