From: YueHaibing <yuehaibing@huawei.com>
To: <mpe@ellerman.id.au>, <benh@kernel.crashing.org>,
<paulus@samba.org>, <gregkh@linuxfoundation.org>,
<christophe.leroy@c-s.fr>, <allison@lohutok.net>,
<armijn@tjaldur.nl>, <tglx@linutronix.de>,
<aneesh.kumar@linux.ibm.com>, <yuehaibing@huawei.com>
Cc: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] powerpc/mm: ptdump: Add missing include <asm/hvcall.h>
Date: Fri, 3 Apr 2020 14:47:56 +0800 [thread overview]
Message-ID: <20200403064756.36128-1-yuehaibing@huawei.com> (raw)
In-Reply-To: <20200402135828.37308-1-yuehaibing@huawei.com>
while PPC_PSERIES is not set, gcc build fails:
arch/powerpc/mm/ptdump/hashpagetable.c: In function ‘pseries_find’:
arch/powerpc/mm/ptdump/hashpagetable.c:262:18: error: ‘H_SUCCESS’ undeclared (first use in this function); did you mean ‘FL_ACCESS’?
if (lpar_rc != H_SUCCESS)
^~~~~~~~~
FL_ACCESS
If PPC_PSERIES is not set, <asm/plpar_wrappers.h> does not
include <asm/hvcall.h>, which leads to this failure.
Add missing include file <asm/hvcall.h> in hashpagetable.c to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 65e701b2d2a8 ("powerpc/ptdump: drop non vital #ifdefs")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: Add hvcall.h instead of vio.h, also rework patch log
---
arch/powerpc/mm/ptdump/hashpagetable.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/mm/ptdump/hashpagetable.c b/arch/powerpc/mm/ptdump/hashpagetable.c
index b6ed9578382f..3e7e6206688c 100644
--- a/arch/powerpc/mm/ptdump/hashpagetable.c
+++ b/arch/powerpc/mm/ptdump/hashpagetable.c
@@ -20,6 +20,7 @@
#include <asm/page.h>
#include <asm/pgalloc.h>
#include <asm/plpar_wrappers.h>
+#include <asm/hvcall.h>
#include <linux/memblock.h>
#include <asm/firmware.h>
--
2.17.1
prev parent reply other threads:[~2020-04-03 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 13:58 [PATCH] powerpc/mm: ptdump: Add missing include <asm/vio.h> YueHaibing
2020-04-03 4:58 ` Michael Ellerman
2020-04-03 6:26 ` Yuehaibing
2020-04-03 6:47 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403064756.36128-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=allison@lohutok.net \
--cc=aneesh.kumar@linux.ibm.com \
--cc=armijn@tjaldur.nl \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).