From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
mhocko@suse.com, linux-mm@kvack.org, dan.j.williams@intel.com,
shile.zhang@linux.alibaba.com, daniel.m.jordan@oracle.com,
ktkhai@virtuozzo.com, david@redhat.com, jmorris@namei.org,
sashal@kernel.org, vbabka@suse.cz
Subject: Re: [PATCH v3 3/3] mm: call cond_resched() from deferred_init_memmap()
Date: Fri, 3 Apr 2020 09:44:39 -0400 [thread overview]
Message-ID: <20200403134439.li6i635dnur5jdha@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <20200403133549.14338-4-pasha.tatashin@soleen.com>
On Fri, Apr 03, 2020 at 09:35:49AM -0400, Pavel Tatashin wrote:
> Now that deferred pages are initialized with interrupts enabled we can
> replace touch_nmi_watchdog() with cond_resched(), as it was before
> 3a2d7fa8a3d5.
...
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 4a60f2427eb0..445f74358997 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1816,7 +1816,7 @@ static int __init deferred_init_memmap(void *data)
> */
> while (spfn < epfn) {
> nr_pages += deferred_init_maxorder(&i, zone, &spfn, &epfn);
> - touch_nmi_watchdog();
> + sched_clock();
I think you meant cond_resched()?
With that,
Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>
next prev parent reply other threads:[~2020-04-03 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 13:35 [PATCH v3 0/3] initialize deferred pages with interrupts enabled Pavel Tatashin
2020-04-03 13:35 ` [PATCH v3 1/3] mm: call touch_nmi_watchdog() on max order boundaries in deferred init Pavel Tatashin
2020-04-03 13:35 ` [PATCH v3 2/3] mm: initialize deferred pages with interrupts enabled Pavel Tatashin
2020-04-03 13:35 ` [PATCH v3 3/3] mm: call cond_resched() from deferred_init_memmap() Pavel Tatashin
2020-04-03 13:44 ` Daniel Jordan [this message]
2020-04-03 14:03 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403134439.li6i635dnur5jdha@ca-dmjordan1.us.oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jmorris@namei.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=sashal@kernel.org \
--cc=shile.zhang@linux.alibaba.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).