From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F2D2C43331 for ; Fri, 3 Apr 2020 16:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 571DF206F5 for ; Fri, 3 Apr 2020 16:40:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HTEn98TA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390999AbgDCQkG (ORCPT ); Fri, 3 Apr 2020 12:40:06 -0400 Received: from merlin.infradead.org ([205.233.59.134]:47212 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728381AbgDCQkG (ORCPT ); Fri, 3 Apr 2020 12:40:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4dF2QsJUGR4Xl/636zq9DlSyKEjw2qbunG9s4a650M8=; b=HTEn98TABr1GK/mBH+hQpcrz4+ u5DXndV2SMsCbsNk5LXFX7fSXOUltRHU6cVPzTkVBaWaMPfWofUJMjpnd2f9P7O5PIK3IHbv+nCLd lFAEoi7NYYnOuwsk6V06cjXSXR9Q97+JOpWBBNpsIXAeovSQE9Ks1+UrDPQxsjP3AxMhRr5oNmUZe u+tj1nllTMYRpB3CK8B7GnYq2naLslUIwXUwKI97FnNmIPnQPpHSURBwfbqvNuhwKo2iT/jDw3qy1 y5DMuTykVqNACNbXNwXtygbHbI66o4FRPf445FOBrKA2MRKwJhgYHb3jNmDU55FITJy/ykzrQHc1E q7AvaIBA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jKPM6-0003G4-FJ; Fri, 03 Apr 2020 16:39:42 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 1FC0F3010BC; Fri, 3 Apr 2020 18:39:41 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 09F542B124BEE; Fri, 3 Apr 2020 18:39:41 +0200 (CEST) Date: Fri, 3 Apr 2020 18:39:41 +0200 From: Peter Zijlstra To: David Laight Cc: Sean Christopherson , Jessica Yu , Rasmus Villemoes , Thomas Gleixner , LKML , "x86@kernel.org" , "Kenneth R. Crudup" , Paolo Bonzini , Fenghua Yu , Xiaoyao Li , Nadav Amit , Thomas Hellstrom , Tony Luck , Steven Rostedt , Greg Kroah-Hartman , "jannh@google.com" , "keescook@chromium.org" Subject: Re: [patch 1/2] x86,module: Detect VMX modules and disable Split-Lock-Detect Message-ID: <20200403163941.GW20730@hirez.programming.kicks-ass.net> References: <20200402123258.895628824@linutronix.de> <20200402124205.242674296@linutronix.de> <20200403143459.GA30424@linux-8ccs> <20200403152158.GR20730@hirez.programming.kicks-ass.net> <20200403160156.GA2701@linux.intel.com> <20200403161205.GT20730@hirez.programming.kicks-ass.net> <7b83b632e41c48698ab892b07673f42d@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b83b632e41c48698ab892b07673f42d@AcuMS.aculab.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 03, 2020 at 04:16:38PM +0000, David Laight wrote: > From: Peter Zijlstra > > Sent: 03 April 2020 17:12 > > On Fri, Apr 03, 2020 at 09:01:56AM -0700, Sean Christopherson wrote: > > > On Fri, Apr 03, 2020 at 05:21:58PM +0200, Peter Zijlstra wrote: > > > > On Fri, Apr 03, 2020 at 04:35:00PM +0200, Jessica Yu wrote: > > > > > > > I wonder if it would make sense then to limit the text scans to just > > > > > out-of-tree modules (i.e., missing the intree modinfo flag)? > > > > > > > > It would; didn't know there was one. > > > > > > Rather than scanning modules at all, what about hooking native_write_cr4() > > > to kill SLD if CR4.VMXE is toggled on and the caller didn't increment a > > > "sld safe" counter? > > > > And then you're hoping that the module uses that and not: > > > > asm volatile ("mov %0, cr4" :: "r" (val)); > > > > I think I feel safer with the scanning to be fair. Also with the intree > > hint on, we can extend the scanning for out-of-tree modules for more > > dodgy crap we really don't want modules to do, like for example the > > above. > > Could you do the scanning in the last phase of the module build > that has to be done against the target kernel headers and with the > target kernel build infrastructure? You think the binary module people care to respect our module build warnings?