From: Greg KH <gregkh@linuxfoundation.org>
To: madhuparnabhowmik10@gmail.com
Cc: hariprasad.kelam@gmail.com, colin.king@canonical.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org, andrianov@ispras.ru,
stern@rowland.harvard.edu
Subject: Re: [PATCH] usb: host: u132-hcd: Remove u132_static_list and list head u132_list
Date: Sat, 4 Apr 2020 11:23:08 +0200 [thread overview]
Message-ID: <20200404092308.GB1110038@kroah.com> (raw)
In-Reply-To: <20200403181816.8115-1-madhuparnabhowmik10@gmail.com>
On Fri, Apr 03, 2020 at 11:48:16PM +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> u132_static_list is a global list protected by u132_module_lock.
> It is read in the u132_hcd_exit() function without holding the lock
> thus may lead to data race.
> However, it turns out that this list isn't used for anything useful
> and thus it is okay to get rid of it.
> Thus, remove the u132_static_list from u132-hcd module.
> Also remove struct list_head u132_list from struct u132.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Suggested-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> ---
> drivers/usb/host/u132-hcd.c | 10 ----------
> 1 file changed, 10 deletions(-)
Please properly version your patches, otherwise I have no idea what
changed from the previous one, nor do I know which patch to take over
which.
The instructions for how to do this is in the documentation. Please fix
up and resend so I have a chance to know what to do...
thanks,
greg k-h
next prev parent reply other threads:[~2020-04-04 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 18:18 [PATCH] usb: host: u132-hcd: Remove u132_static_list and list head u132_list madhuparnabhowmik10
2020-04-04 9:23 ` Greg KH [this message]
2020-04-04 17:39 ` Madhuparna Bhowmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200404092308.GB1110038@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrianov@ispras.ru \
--cc=colin.king@canonical.com \
--cc=hariprasad.kelam@gmail.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).