From: Jonathan Cameron <jic23@kernel.org>
To: "Sa, Nuno" <Nuno.Sa@analog.com>
Cc: Rohit Sarkar <rohitsarkar5398@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] iio: imu: adis16460: use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE
Date: Sat, 4 Apr 2020 16:34:08 +0100 [thread overview]
Message-ID: <20200404163408.61a8c77e@archlinux> (raw)
In-Reply-To: <BN6PR03MB33478A31AA2CF52CF3A81AB999C80@BN6PR03MB3347.namprd03.prod.outlook.com>
On Tue, 31 Mar 2020 15:28:22 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:
> > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> On
> > Behalf Of Rohit Sarkar
> > Sent: Dienstag, 31. März 2020 13:48
> > To: linux-iio@vger.kernel.org
> > Cc: Bogdan, Dragos <Dragos.Bogdan@analog.com>; Rohit Sarkar
> > <rohitsarkar5398@gmail.com>; Lars-Peter Clausen <lars@metafoo.de>;
> > Hennerich, Michael <Michael.Hennerich@analog.com>; Stefan Popa
> > <stefan.popa@analog.com>; Jonathan Cameron <jic23@kernel.org>; Hartmut
> > Knaack <knaack.h@gmx.de>; Peter Meerwald-Stadler
> > <pmeerw@pmeerw.net>; linux-kernel@vger.kernel.org
> > Subject: [PATCH v2 2/2] iio: imu: adis16460: use
> > DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE
> >
> > debugfs_create_file_unsafe does not protect the fops handed to it
> > against file removal. DEFINE_DEBUGFS_ATTRIBUTE makes the fops aware of
> > the file lifetime and thus protects it against removal.
> >
> > Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> > ---
> > drivers/iio/imu/adis16460.c | 27 +++++++++++++++------------
> > 1 file changed, 15 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/iio/imu/adis16460.c b/drivers/iio/imu/adis16460.c
> > index 9539cfe4a259..f96cfd007957 100644
> > --- a/drivers/iio/imu/adis16460.c
> > +++ b/drivers/iio/imu/adis16460.c
> > @@ -87,8 +87,8 @@ static int adis16460_show_serial_number(void *arg,
> > u64 *val)
> >
> > return 0;
> > }
> > -DEFINE_SIMPLE_ATTRIBUTE(adis16460_serial_number_fops,
> > - adis16460_show_serial_number, NULL, "0x%.4llx\n");
> > +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_serial_number_fops,
> > + adis16460_show_serial_number, NULL, "0x%.4llx\n");
> >
> > static int adis16460_show_product_id(void *arg, u64 *val)
> > {
> > @@ -105,8 +105,8 @@ static int adis16460_show_product_id(void *arg, u64
> > *val)
> >
> > return 0;
> > }
> > -DEFINE_SIMPLE_ATTRIBUTE(adis16460_product_id_fops,
> > - adis16460_show_product_id, NULL, "%llu\n");
> > +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_product_id_fops,
> > + adis16460_show_product_id, NULL, "%llu\n");
> >
> > static int adis16460_show_flash_count(void *arg, u64 *val)
> > {
> > @@ -123,19 +123,22 @@ static int adis16460_show_flash_count(void *arg,
> > u64 *val)
> >
> > return 0;
> > }
> > -DEFINE_SIMPLE_ATTRIBUTE(adis16460_flash_count_fops,
> > - adis16460_show_flash_count, NULL, "%lld\n");
> > +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_flash_count_fops,
> > + adis16460_show_flash_count, NULL, "%lld\n");
> >
> > static int adis16460_debugfs_init(struct iio_dev *indio_dev)
> > {
> > struct adis16460 *adis16460 = iio_priv(indio_dev);
> >
> > - debugfs_create_file("serial_number", 0400, indio_dev-
> > >debugfs_dentry,
> > - adis16460, &adis16460_serial_number_fops);
> > - debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry,
> > - adis16460, &adis16460_product_id_fops);
> > - debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry,
> > - adis16460, &adis16460_flash_count_fops);
> > + debugfs_create_file_unsafe("serial_number", 0400,
> > + indio_dev->debugfs_dentry, adis16460,
> > + &adis16460_serial_number_fops);
> > + debugfs_create_file_unsafe("product_id", 0400,
> > + indio_dev->debugfs_dentry, adis16460,
> > + &adis16460_product_id_fops);
> > + debugfs_create_file_unsafe("flash_count", 0400,
> > + indio_dev->debugfs_dentry, adis16460,
> > + &adis16460_flash_count_fops);
> >
> > return 0;
> > }
>
> Tested-by Nuno Sá <nuno.sa@analog.com>
Applied. Thanks,
Jonathan
>
> > --
> > 2.23.0.385.gbc12974a89
>
prev parent reply other threads:[~2020-04-04 15:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 6:34 [PATCH 0/2] use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE Rohit Sarkar
2020-03-28 6:34 ` [PATCH 1/2] iio: imu: adis16400: " Rohit Sarkar
2020-03-28 6:34 ` [PATCH 2/2] iio: imu: adis16460: " Rohit Sarkar
2020-03-29 9:38 ` [PATCH 0/2] " Jonathan Cameron
2020-03-29 11:34 ` Rohit Sarkar
2020-03-29 13:46 ` Lars-Peter Clausen
2020-03-29 15:39 ` Rohit Sarkar
2020-03-30 9:20 ` Ardelean, Alexandru
2020-03-31 10:58 ` Sa, Nuno
2020-03-31 11:08 ` Lars-Peter Clausen
2020-03-31 11:19 ` Rohit Sarkar
2020-03-31 11:49 ` Rohit Sarkar
2020-03-31 15:30 ` Sa, Nuno
2020-03-31 11:47 ` [PATCH v2 " Rohit Sarkar
2020-03-31 11:47 ` [PATCH v2 1/2] iio: imu: adis16400: " Rohit Sarkar
2020-03-31 15:28 ` Sa, Nuno
2020-04-04 15:32 ` Jonathan Cameron
2020-03-31 11:47 ` [PATCH v2 2/2] iio: imu: adis16460: " Rohit Sarkar
2020-03-31 15:28 ` Sa, Nuno
2020-04-04 15:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200404163408.61a8c77e@archlinux \
--to=jic23@kernel.org \
--cc=Dragos.Bogdan@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rohitsarkar5398@gmail.com \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).