From: Tang Bin <tangbin@cmss.chinamobile.com>
To: sre@kernel.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Tang Bin <tangbin@cmss.chinamobile.com>
Subject: [PATCH] [PATCH v2] power:supply:88pm860x_battery:remove redundant dev_err message
Date: Mon, 6 Apr 2020 13:07:57 +0800 [thread overview]
Message-ID: <20200406050757.13796-1-tangbin@cmss.chinamobile.com> (raw)
In the pm860x_battery_probe(),when get irq failed, the function
platform_get_irq() can log an dev_err message,so remove redundant
message here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
Changes from v1
- changed the theme、commit message and the code,but the purpose is the same.
The original piece is:https://lore.kernel.org/linux-pm/20200402111222.15204-1-tangbin@cmss.chinamobile.com/
---
drivers/power/supply/88pm860x_battery.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/power/supply/88pm860x_battery.c b/drivers/power/supply/88pm860x_battery.c
index 5ca047b3f..1308f3a18 100644
--- a/drivers/power/supply/88pm860x_battery.c
+++ b/drivers/power/supply/88pm860x_battery.c
@@ -919,16 +919,12 @@ static int pm860x_battery_probe(struct platform_device *pdev)
return -ENOMEM;
info->irq_cc = platform_get_irq(pdev, 0);
- if (info->irq_cc <= 0) {
- dev_err(&pdev->dev, "No IRQ resource!\n");
+ if (info->irq_cc <= 0)
return -EINVAL;
- }
info->irq_batt = platform_get_irq(pdev, 1);
- if (info->irq_batt <= 0) {
- dev_err(&pdev->dev, "No IRQ resource!\n");
+ if (info->irq_batt <= 0)
return -EINVAL;
- }
info->chip = chip;
info->i2c =
--
2.20.1.windows.1
next reply other threads:[~2020-04-06 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 5:07 Tang Bin [this message]
2020-04-13 23:04 ` [PATCH] [PATCH v2] power:supply:88pm860x_battery:remove redundant dev_err message Sebastian Reichel
2020-04-14 7:08 ` [PATCH] [PATCH v2] power:supply:88pm860x_battery:removeredundant " Tang Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406050757.13796-1-tangbin@cmss.chinamobile.com \
--to=tangbin@cmss.chinamobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).