* [PATCH] video: fbdev: don't print error message on platform_get_irq() failure
@ 2020-04-06 5:34 Tang Bin
2020-04-06 14:13 ` Nicolas Ferre
2020-04-07 18:18 ` Sam Ravnborg
0 siblings, 2 replies; 3+ messages in thread
From: Tang Bin @ 2020-04-06 5:34 UTC (permalink / raw)
To: b.zolnierkie, nicolas.ferre, alexandre.belloni,
ludovic.desroches, linux-fbdev, dri-devel
Cc: linux-arm-kernel, linux-kernel, Tang Bin
The platform_get_irq() can print error message,so remove the redundant
dev_err() here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/video/fbdev/atmel_lcdfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
index d567f5d56..1e2521925 100644
--- a/drivers/video/fbdev/atmel_lcdfb.c
+++ b/drivers/video/fbdev/atmel_lcdfb.c
@@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
sinfo->irq_base = platform_get_irq(pdev, 0);
if (sinfo->irq_base < 0) {
- dev_err(dev, "unable to get irq\n");
ret = sinfo->irq_base;
goto stop_clk;
}
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: don't print error message on platform_get_irq() failure
2020-04-06 5:34 [PATCH] video: fbdev: don't print error message on platform_get_irq() failure Tang Bin
@ 2020-04-06 14:13 ` Nicolas Ferre
2020-04-07 18:18 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2020-04-06 14:13 UTC (permalink / raw)
To: Tang Bin, b.zolnierkie, alexandre.belloni, ludovic.desroches,
linux-fbdev, dri-devel
Cc: linux-arm-kernel, linux-kernel
On 06/04/2020 at 07:34, Tang Bin wrote:
> The platform_get_irq() can print error message,so remove the redundant
> dev_err() here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/video/fbdev/atmel_lcdfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
> index d567f5d56..1e2521925 100644
> --- a/drivers/video/fbdev/atmel_lcdfb.c
> +++ b/drivers/video/fbdev/atmel_lcdfb.c
> @@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
>
> sinfo->irq_base = platform_get_irq(pdev, 0);
> if (sinfo->irq_base < 0) {
> - dev_err(dev, "unable to get irq\n");
> ret = sinfo->irq_base;
> goto stop_clk;
> }
> --
> 2.20.1.windows.1
>
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: don't print error message on platform_get_irq() failure
2020-04-06 5:34 [PATCH] video: fbdev: don't print error message on platform_get_irq() failure Tang Bin
2020-04-06 14:13 ` Nicolas Ferre
@ 2020-04-07 18:18 ` Sam Ravnborg
1 sibling, 0 replies; 3+ messages in thread
From: Sam Ravnborg @ 2020-04-07 18:18 UTC (permalink / raw)
To: Tang Bin
Cc: b.zolnierkie, nicolas.ferre, alexandre.belloni,
ludovic.desroches, linux-fbdev, dri-devel, linux-kernel,
linux-arm-kernel
Hi Tang Bin
On Mon, Apr 06, 2020 at 01:34:50PM +0800, Tang Bin wrote:
> The platform_get_irq() can print error message,so remove the redundant
> dev_err() here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/video/fbdev/atmel_lcdfb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
> index d567f5d56..1e2521925 100644
> --- a/drivers/video/fbdev/atmel_lcdfb.c
> +++ b/drivers/video/fbdev/atmel_lcdfb.c
> @@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
>
> sinfo->irq_base = platform_get_irq(pdev, 0);
> if (sinfo->irq_base < 0) {
> - dev_err(dev, "unable to get irq\n");
> ret = sinfo->irq_base;
> goto stop_clk;
> }
Thanks, applied to drm-misc-next. The fix will appear in kernel 5.8
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-07 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 5:34 [PATCH] video: fbdev: don't print error message on platform_get_irq() failure Tang Bin
2020-04-06 14:13 ` Nicolas Ferre
2020-04-07 18:18 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).