From: Lee Jones <lee.jones@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: kgunda@codeaurora.org, Rob Herring <robh@kernel.org>,
bjorn.andersson@linaro.org, jingoohan1@gmail.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
jacek.anaszewski@gmail.com, pavel@ucw.cz, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
linux-arm-msm@vger.kernel.org,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>
Subject: Re: [PATCH V4 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format
Date: Mon, 6 Apr 2020 09:50:24 +0100 [thread overview]
Message-ID: <20200406085024.GF30614@dell> (raw)
In-Reply-To: <20200403114651.m6rholzufzqinanc@holly.lan>
On Fri, 03 Apr 2020, Daniel Thompson wrote:
> On Fri, Apr 03, 2020 at 04:45:49PM +0530, kgunda@codeaurora.org wrote:
> > On 2020-03-31 23:24, Rob Herring wrote:
> > > On Mon, Mar 23, 2020 at 11:16:55PM +0530, Kiran Gunda wrote:
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
> > > > b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
> > > > new file mode 100644
> > > > index 0000000..8a388bf
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
> > > > @@ -0,0 +1,184 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/leds/backlight/qcom-wled.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Binding for Qualcomm Technologies, Inc. WLED driver
> > > > +
> > > > +maintainers:
> > > > + - Lee Jones <lee.jones@linaro.org>
> > >
> > > Should be the h/w owner (you), not who applies patches.
> > >
> > will address in next post.
> > <snip>
> > will address in next post.
> > <snip>
> > will address in next post.
> > <snip>
> > will address in next post.
> > <snip>
> > will address in next post.
> > <snip>
> > will address in next post.
> > <snip>
> > will address in next post.
> > <snip>
> > will address in next post.
> > <snip>
> > will address in next post.
>
> If you agree on all points raised I doubt there is any need for a point
> by point reply since everyone who reads it will have to scroll down
> simply to find out that you agree on all points.
>
> Better just to acknowledge the feedback and reply to the first one
> saying you'll agree on all points and will address all feedback in the
> next revision (and then trim the reply to keep it short).
Or better still, just submit the next revision with all the fixes. :)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-04-06 8:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 17:46 [PATCH V4 0/4] Add support for WLED5 Kiran Gunda
2020-03-23 17:46 ` [PATCH V4 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format Kiran Gunda
2020-03-31 17:54 ` Rob Herring
2020-04-03 11:15 ` kgunda
2020-04-03 11:46 ` Daniel Thompson
2020-04-06 8:50 ` Lee Jones [this message]
2020-04-13 14:50 ` kgunda
2020-03-23 17:46 ` [PATCH V4 2/4] backlight: qcom-wled: Add callback functions Kiran Gunda
2020-03-25 15:30 ` Daniel Thompson
2020-03-30 14:45 ` kgunda
2020-03-23 17:46 ` [PATCH V4 3/4] backlight: qcom-wled: Add WLED5 bindings Kiran Gunda
2020-03-25 15:37 ` Daniel Thompson
2020-03-30 14:28 ` kgunda
2020-03-31 17:56 ` Rob Herring
2020-04-03 11:17 ` kgunda
2020-03-23 17:46 ` [PATCH V4 4/4] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L Kiran Gunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406085024.GF30614@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).