From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC3BC2BA17 for ; Mon, 6 Apr 2020 15:58:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51BAE248A3 for ; Mon, 6 Apr 2020 15:58:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LmMhIiHB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729263AbgDFP6z (ORCPT ); Mon, 6 Apr 2020 11:58:55 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:40710 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729202AbgDFP6z (ORCPT ); Mon, 6 Apr 2020 11:58:55 -0400 Received: by mail-pl1-f193.google.com with SMTP id h11so6079141plk.7 for ; Mon, 06 Apr 2020 08:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WhhzEvhj7V6SaqGfbxM9gAfOTnFcEdBBvYMHzIDChN4=; b=LmMhIiHBv8JKUwBK1L17Slsqu3pI1ZCj3WAAiYxR/QFR1qVVAz4IYPwxfWMPMZ7zXm 9Wax7svqkeAr2xHTEIyNbAJ/iUo4weccl0+nxbm3QSdyRtI1nG9no3Rpx1h0oKuXEq2s oLCH+OVR+6Db2zO7UsCV6KbjY1WiOXXI8xjXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WhhzEvhj7V6SaqGfbxM9gAfOTnFcEdBBvYMHzIDChN4=; b=UsxkLupsopQywb+dzz4gzaZRrEynRqEGYoHYN8TqTSYqRliUmdE7yHEEDdtw1rgJSM on/ZkTw6uc1LzEagxeQ+KmWlKN3isIDclcaC4Ak8TdOwCMVt9Yy4u6aLLqCvjR8oi0GL TofXBngQ2q2SHdn01VFIlMTd/1PhVqiLEU+2utW8LAdsgRpeVuYYr2In+hEr/zKqC+Gr +PS0qOquceTHUUGS7MOeOM7MZ7AHfta+vndQrwAR8y54BIyMS2LgH4qDU8dZ2i6ttz+M TdcsYkO9xOg9lXLg07XJs5jUE9UoJE2bYOCL6eAmyQ4BsgG777lmfMSGSPGtuQc/M9Z3 I3VQ== X-Gm-Message-State: AGi0PuYppslLuYww8rKbK5FQ4QXZkPSXXLYMpxwJX4W+GRehIiq2dEHN 8oCw38ZFAKeA7NyHPSbBk0h++A== X-Google-Smtp-Source: APiQypJ454SwMkM4BAp+LRIUIyKBkrYFbcaUu2UEQwNI+5DjasWsw/sS58aewnFEQncDuWljFvZJ8Q== X-Received: by 2002:a17:902:7203:: with SMTP id ba3mr20816991plb.37.1586188732549; Mon, 06 Apr 2020 08:58:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r64sm24942pjb.15.2020.04.06.08.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 08:58:51 -0700 (PDT) Date: Mon, 6 Apr 2020 08:58:50 -0700 From: Kees Cook To: Luis Chamberlain Cc: Vlastimil Babka , Iurii Zaikin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-mm@kvack.org, Ivan Teterevkov , Michal Hocko , David Rientjes , Matthew Wilcox , "Eric W . Biederman" , "Guilherme G . Piccoli" , Alexey Dobriyan , Thomas Gleixner , Greg Kroah-Hartman , Christian Brauner Subject: Re: [PATCH 1/3] kernel/sysctl: support setting sysctl parameters from kernel command line Message-ID: <202004060856.6BC17C5C99@keescook> References: <20200330115535.3215-1-vbabka@suse.cz> <20200330115535.3215-2-vbabka@suse.cz> <20200330224422.GX11244@42.do-not-panic.com> <287ac6ae-a898-3e68-c7d8-4c1d17a40db9@suse.cz> <20200402160442.GA11244@42.do-not-panic.com> <202004021017.3A23B759@keescook> <20200402205932.GM11244@42.do-not-panic.com> <202004031654.C4389A04EF@keescook> <20200406140836.GA11244@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200406140836.GA11244@42.do-not-panic.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 06, 2020 at 02:08:36PM +0000, Luis Chamberlain wrote: > > Yes. Doing an internal extension isn't testing the actual code. > > But it would. > > [...] > > I don't think anything is needed for this series. It can be boot tested > > manually. > > Why test it manually when it could be tested automatically with a new kconfig? So, my impression is that adding code to the internals to test the internals isn't a valid test (or at least makes it fragile) because the test would depend on the changes to the internals (or at least depend on non-default non-production CONFIGs). Can you send a patch for what you think this should look like? Perhaps I'm not correctly imagining what you're describing? Regardless of testing, I think this series is ready for -mm. -- Kees Cook