From: Davidlohr Bueso <dave@stgolabs.net>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: Michel Lespinasse <walken@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Liam Howlett <Liam.Howlett@oracle.com>,
Jerome Glisse <jglisse@redhat.com>,
David Rientjes <rientjes@google.com>,
Hugh Dickins <hughd@google.com>, Ying Han <yinghan@google.com>
Subject: Re: [PATCH 8/8] mmap locking API: rename mmap_sem to mmap_lock
Date: Mon, 6 Apr 2020 09:03:56 -0700 [thread overview]
Message-ID: <20200406160356.py26by67dhprte5d@linux-p48b> (raw)
In-Reply-To: <4eaa33a1-8144-253e-ac99-eeb354b6f871@linux.ibm.com>
On Mon, 06 Apr 2020, Laurent Dufour wrote:
>Le 26/03/2020 à 08:02, Michel Lespinasse a écrit :
>>Rename the mmap_sem field to mmap_lock. Any new uses of this lock
>>should now go through the new mmap locking api. The mmap_lock is
>>still implemented as a rwsem, though this could change in the future.
>
>Since you don't change the type of the mmap_sem, it's still a
>semaphore, I don't think mmap_lock is a good name. This is not a lock.
Well a semaphore is still a kind of lock. I think the naming in this
patch is good and generic enough.
Thanks,
Davidlohr
next prev parent reply other threads:[~2020-04-06 18:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 7:02 [PATCH 0/8] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-03-26 7:02 ` [PATCH 1/8] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-03-26 17:56 ` Jason Gunthorpe
2020-03-26 18:06 ` Matthew Wilcox
2020-03-26 18:09 ` Matthew Wilcox
2020-03-26 22:09 ` Michel Lespinasse
2020-03-26 7:02 ` [PATCH 2/8] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-03-26 7:02 ` [PATCH 3/8] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-03-26 7:02 ` [PATCH 4/8] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-03-26 7:02 ` [PATCH 5/8] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-03-26 12:09 ` Matthew Wilcox
2020-03-26 12:56 ` Michel Lespinasse
2020-03-26 7:02 ` [PATCH 6/8] mmap locking API: add mmap_read_release() and mmap_read_unlock_non_owner() Michel Lespinasse
2020-03-26 7:02 ` [PATCH 7/8] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-04-06 9:46 ` Laurent Dufour
2020-04-06 13:04 ` Michel Lespinasse
2020-03-26 7:02 ` [PATCH 8/8] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-04-06 12:45 ` Laurent Dufour
2020-04-06 13:17 ` Michel Lespinasse
2020-04-06 16:03 ` Davidlohr Bueso [this message]
2020-03-26 7:13 ` [PATCH 0/8] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406160356.py26by67dhprte5d@linux-p48b \
--to=dave@stgolabs.net \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=willy@infradead.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).