From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B17AC2BA17 for ; Mon, 6 Apr 2020 17:21:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E24EA249C8 for ; Mon, 6 Apr 2020 17:21:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="mfypNZvv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729872AbgDFRVJ (ORCPT ); Mon, 6 Apr 2020 13:21:09 -0400 Received: from mail.skyhub.de ([5.9.137.197]:49906 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728736AbgDFRVI (ORCPT ); Mon, 6 Apr 2020 13:21:08 -0400 Received: from zn.tnic (p200300EC2F04F600C1A00E803BF5BF5B.dip0.t-ipconnect.de [IPv6:2003:ec:2f04:f600:c1a0:e80:3bf5:bf5b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EECE81EC0CDB; Mon, 6 Apr 2020 19:21:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1586193667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=SvlsLYjk7+N+Zi3Q2er0ZEj5L9OiCRt8VPcz7ScDZKE=; b=mfypNZvvlyY+r+up9ukE9DGjblAgXh2d30KFKbtusE5t1QOSN8uHnxvS6f0NExmxrAj7cY fdeOi/I5GNxEg2h/n4TBzcJe6muphSe662lGoK7/wC8xUyqebdUuwvzbX+Rrr5M+l+aDVs 2RkQ8rhtcnNd25eNI8HzVWqZeQV98ts= Date: Mon, 6 Apr 2020 19:21:02 +0200 From: Borislav Petkov To: Ard Biesheuvel , Arvind Sankar Cc: Sergey Shatunov , hpa@zytor.com, Linux Kernel Mailing List , mingo@redhat.com, Thomas Gleixner , x86@kernel.org, linux-efi , initramfs@vger.kernel.org, Donovan Tremura , Harald Hoyer Subject: Re: [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable from bzImage Message-ID: <20200406172102.GF2520@zn.tnic> References: <20200405154245.11972-1-me@prok.pw> <20200405231845.GA3095309@rani.riverdale.lan> <20200406035110.GA3241052@rani.riverdale.lan> <20200406084738.GA2520@zn.tnic> <20200406112042.GC2520@zn.tnic> <20200406132215.GA113388@rani.riverdale.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 06, 2020 at 03:29:18PM +0200, Ard Biesheuvel wrote: > > What do you think of the other problem -- that's actually worse to fix, > > as it won't just be when kaslr is disabled, the startup_64 code will do > > relocation to the end of init_size and clobber the initrd before getting > > to the kaslr code, so it will break as soon as the firmware loads the > > "unified kernel image" at a 2Mb-aligned address. The only thing I can > > think of is to just unconditionally call efi_relocate_kernel if we were > > entered via handover_entry? > > > > Yes, that seems to be the most robust approach. The commit in question is this one: d5cdf4cfeac9 ("efi/x86: Don't relocate the kernel unless necessary") I presume? I'm guessing it can simply be reverted as it doesn't fix a bug but it is just an optimization... provided I'm not missing something, of course. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette