From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4E8C2BA17 for ; Mon, 6 Apr 2020 18:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A837E2072F for ; Mon, 6 Apr 2020 18:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbgDFSsP (ORCPT ); Mon, 6 Apr 2020 14:48:15 -0400 Received: from gardel.0pointer.net ([85.214.157.71]:60830 "EHLO gardel.0pointer.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbgDFSsP (ORCPT ); Mon, 6 Apr 2020 14:48:15 -0400 Received: from gardel-login.0pointer.net (gardel.0pointer.net [85.214.157.71]) by gardel.0pointer.net (Postfix) with ESMTP id 0F440E8017E; Mon, 6 Apr 2020 20:48:13 +0200 (CEST) Received: by gardel-login.0pointer.net (Postfix, from userid 1000) id A7D69161537; Mon, 6 Apr 2020 20:48:12 +0200 (CEST) Date: Mon, 6 Apr 2020 20:48:12 +0200 From: Lennart Poettering To: Linus Torvalds Cc: Karel Zak , "J. Bruce Fields" , Miklos Szeredi , Ian Kent , David Howells , Christian Brauner , Al Viro , dray@redhat.com, Miklos Szeredi , Steven Whitehouse , Jeff Layton , andres@anarazel.de, keyrings@vger.kernel.org, linux-fsdevel , Linux Kernel Mailing List , Aleksa Sarai Subject: Re: Upcoming: Notifications, FS notifications and fsinfo() Message-ID: <20200406184812.GA37843@gardel-login> References: <36e45eae8ad78f7b8889d9d03b8846e78d735d28.camel@themaw.net> <27994c53034c8f769ea063a54169317c3ee62c04.camel@themaw.net> <20200403111144.GB34663@gardel-login> <20200403151223.GB34800@gardel-login> <20200403203024.GB27105@fieldses.org> <20200406091701.q7ctdek2grzryiu3@ws.net.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mo, 06.04.20 09:34, Linus Torvalds (torvalds@linux-foundation.org) wrote: > On Mon, Apr 6, 2020 at 2:17 AM Karel Zak wrote: > > > > On Fri, Apr 03, 2020 at 04:30:24PM -0400, J. Bruce Fields wrote: > > > > > > nfs-utils/support/misc/mountpoint.c:check_is_mountpoint() stats the file > > > and ".." and returns true if they have different st_dev or the same > > > st_ino. Comparing mount ids sounds better. > > > > BTW, this traditional st_dev+st_ino way is not reliable for bind mounts. > > For mountpoint(1) we search the directory in /proc/self/mountinfo. > > These days you should probably use openat2() with RESOLVE_NO_XDEV. Note that opening a file is relatively "heavy" i.e. typically triggers autofs and stuff, and results in security checks (which can fail and such, and show up in audit). statx() doesn't do that, and that's explicitly documented (i.e. AT_NO_AUTOMOUNT and stuff). Hence, unless openat2() has some mechanism of doing something like an "open() but not really" (O_PATH isn't really sufficient for this, no?) I don't think it could be a good replacement for a statx() type check if something is a mount point or not. I mean, think about usecases: a common usecase for "is this a mountpoint" checks are tools that traverse directory trees and want to stop at submounts. They generally try to minimize operations and hence stat stuff but don't open anything unless its what they look foor (or a subdir they identified as a non-submount). Doing an extra openat2() in between there doesn't sound so attractive, since you pay heavily... Lennart -- Lennart Poettering, Berlin