From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"David Heidelberg" <david@ixit.cz>,
"Peter Geis" <pgwipeout@gmail.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Nicolas Chauvet" <kwizart@gmail.com>,
"Pedro Ângelo" <pangelo@void.io>,
"Matt Merhar" <mattmerhar@protonmail.com>,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] ARM: tegra: Add device-tree for ASUS Google Nexus 7
Date: Tue, 7 Apr 2020 12:50:53 +0200 [thread overview]
Message-ID: <20200407105053.GD1720957@ulmo> (raw)
In-Reply-To: <20200406194110.21283-3-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
On Mon, Apr 06, 2020 at 10:41:06PM +0300, Dmitry Osipenko wrote:
[...]
> diff --git a/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi b/arch/arm/boot/dts/tegra30-asus-nexus7-grouper-common.dtsi
[...]
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + linux,cma@80000000 {
> + compatible = "shared-dma-pool";
> + alloc-ranges = <0x80000000 0x30000000>;
> + size = <0x10000000>; /* 256MiB */
> + linux,cma-default;
> + reusable;
> + };
> +
> + ramoops@bfdf0000 {
> + compatible = "ramoops";
> + reg = <0xbfdf0000 0x10000>; /* 64kB */
> + console-size = <0x8000>; /* 32kB */
> + record-size = <0x400>; /* 1kB */
> + ecc-size = <16>;
> + };
> +
> + trust_zone@bfe00000 {
Given that this is trademarked as "TrustZone", perhaps drop the
underscore?
Other than that, the same comments as for the Acer tablet patch also
apply here.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-07 10:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 19:41 [PATCH v2 0/6] Support NVIDIA Tegra-based Acer A500 and Nexus 7 devices Dmitry Osipenko
2020-04-06 19:41 ` [PATCH v2 1/6] ARM: tegra: Add device-tree for Acer Iconia Tab A500 Dmitry Osipenko
2020-04-07 10:41 ` Thierry Reding
2020-04-07 16:23 ` Dmitry Osipenko
2020-04-06 19:41 ` [PATCH v2 2/6] ARM: tegra: Add device-tree for ASUS Google Nexus 7 Dmitry Osipenko
2020-04-07 10:50 ` Thierry Reding [this message]
2020-04-06 19:41 ` [PATCH v2 3/6] dt-bindings: Add vendor prefix for Acer Inc Dmitry Osipenko
2020-04-06 19:41 ` [PATCH v2 4/6] dt-bindings: ARM: tegra: Add Acer Iconia Tab A500 Dmitry Osipenko
2020-04-06 19:41 ` [PATCH v2 5/6] dt-bindings: ARM: tegra: Add ASUS Google Nexus 7 Dmitry Osipenko
2020-04-06 19:41 ` [PATCH v2 6/6] ARM: tegra_defconfig: Enable options useful for Nexus 7 and Acer A500 Dmitry Osipenko
2020-04-07 10:08 ` Thierry Reding
2020-04-07 16:38 ` Dmitry Osipenko
2020-04-08 0:37 ` Peter Geis
2020-04-08 14:40 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407105053.GD1720957@ulmo \
--to=thierry.reding@gmail.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pangelo@void.io \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).