linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alex Dewar <alex.dewar@gmx.co.uk>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Qiujun Huang <hqjagain@gmail.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hannes Reinecke <hare@suse.com>,
	"James E. J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: aic7xxx: Remove null pointer checks before kfree()
Date: Tue, 7 Apr 2020 16:54:53 +0100	[thread overview]
Message-ID: <20200407155453.sosj4brsw6r7fnot@lenovo-laptop> (raw)
In-Reply-To: <72bc89d5-cf50-3f3a-41e0-b46b134e754d@web.de>

Markus,

On Sun, Apr 05, 2020 at 10:02:47PM +0200, Markus Elfring wrote:
> > NULL check before kfree is unnecessary so remove it.
>
> I hope that you would like to take another update suggestion into account
> (besides a typo correction for your commit message).
> https://lore.kernel.org/patchwork/patch/1220189/
> https://lore.kernel.org/linux-scsi/20200403164712.49579-1-alex.dewar@gmx.co.uk/

I'm not sure I understand the relevance. Are you saying I should
reference this other patch?

>
> Do you find a previous update suggestion like “SCSI-aic7...: Delete unnecessary
> checks before the function call "kfree"” also interesting?
> https://lore.kernel.org/linux-scsi/54D3E057.9030600@users.sourceforge.net/
> https://lore.kernel.org/patchwork/patch/540593/
> https://lkml.org/lkml/2015/2/5/650
>

Thanks for the reference. I'll mention it in the commit if I do a v2.

Best,
Alex

> Regards,
> Markus

  parent reply	other threads:[~2020-04-07 15:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-05 20:02 [PATCH] scsi: aic7xxx: Remove null pointer checks before kfree() Markus Elfring
2020-04-06  1:14 ` Qiujun Huang
2020-04-07 15:54 ` Alex Dewar [this message]
2020-04-07 16:32   ` Markus Elfring
2020-04-09 11:48     ` Alex Dewar
2020-04-09 14:27       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200407155453.sosj4brsw6r7fnot@lenovo-laptop \
    --to=alex.dewar@gmx.co.uk \
    --cc=Markus.Elfring@web.de \
    --cc=hare@suse.com \
    --cc=hqjagain@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).