From: Jeff King <peff@peff.net>
To: Olaf Hering <olaf@aepfle.de>
Cc: linux-kernel@vger.kernel.org, git@vger.kernel.org
Subject: Re: get_maintainer.pl sends bogus addresses to git send-email
Date: Tue, 7 Apr 2020 13:02:57 -0400 [thread overview]
Message-ID: <20200407170257.GA1844923@coredump.intra.peff.net> (raw)
In-Reply-To: <20200407154046.GA15368@aepfle.de>
On Tue, Apr 07, 2020 at 05:40:46PM +0200, Olaf Hering wrote:
> For me sending patches via git send-email fails because email address
> conversion is failing. Something appends a ')' to x86/lkml@kernel.org.
> I suspect the double '))' in MAINTAINERS is confusing the command.
> I tried to send the trivial patch from v5.0 and v5.6 tag.
>
> Is this a failure in ./scripts/get_maintainer.pl,
> or is this something git does internally?
> I'm sure others use such command on a daily basis, so likely something on
> my end became broken at some point in the past.
It's a bug in send-email's hand-rolled address parser, which was fixed
in bd869f67b9 (send-email: add and use a local copy of Mail::Address,
2018-01-05). Upgrade to Git v2.17.0 or newer.
-Peff
next prev parent reply other threads:[~2020-04-07 17:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 15:40 get_maintainer.pl sends bogus addresses to git send-email Olaf Hering
2020-04-07 17:02 ` Jeff King [this message]
2020-04-07 17:18 ` Joe Perches
2020-04-07 17:29 ` Olaf Hering
2020-04-07 17:39 ` Joe Perches
2020-04-07 17:44 ` Jeff King
2020-04-07 21:56 ` Joe Perches
2020-04-08 17:28 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407170257.GA1844923@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).