From: Nathan Chancellor <natechancellor@gmail.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
linux-kernel@vger.kernel.org,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH] ARC: [plat-hsdk]: fix USB regression
Date: Tue, 7 Apr 2020 18:59:49 -0700 [thread overview]
Message-ID: <20200408015949.GA40360@ubuntu-s3-xlarge-x86> (raw)
In-Reply-To: <20200408012028.GA40613@ubuntu-s3-xlarge-x86>
On Tue, Apr 07, 2020 at 06:20:28PM -0700, Nathan Chancellor wrote:
> On Tue, Apr 07, 2020 at 07:19:33PM +0300, Eugeniy Paltsev wrote:
> > As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
> > as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
> > in its kconfig.
> > The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> > reverse the dependencies between UDL and USB so UDL now depends on
> > CONFIG_USB and not selects it. This introduces regression for ARC HSDK
> > board as HSDK defconfig wasn't adjusted and now it misses USB support
> > due to lack of CONFIG_USB enabled.
> >
> > Fix that.
> >
> > Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> > ---
> > arch/arc/configs/hsdk_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> > index 0974226fab55..f79c15892704 100644
> > --- a/arch/arc/configs/hsdk_defconfig
> > +++ b/arch/arc/configs/hsdk_defconfig
> > @@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
> > CONFIG_DRM_ETNAVIV=y
> > CONFIG_FB=y
> > CONFIG_FRAMEBUFFER_CONSOLE=y
> > +CONFIG_USB
>
> Shouldn't this be CONFIG_USB=y?
>
> As it stands, this patch does nothing.
>
> Cheers,
> Nathan
Nevermind, I came across v2 on the mailing list, sorry for the noise.
Cheers,
Nathan
prev parent reply other threads:[~2020-04-08 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 16:19 [PATCH] ARC: [plat-hsdk]: fix USB regression Eugeniy Paltsev
2020-04-07 16:22 ` Eugeniy Paltsev
2020-04-08 1:04 ` Masahiro Yamada
2020-04-08 1:20 ` Nathan Chancellor
2020-04-08 1:59 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408015949.GA40360@ubuntu-s3-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).