From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: Export fw_get_builtin_firmware()?
Date: Wed, 8 Apr 2020 12:20:03 +0200 [thread overview]
Message-ID: <20200408102003.GA1070237@kroah.com> (raw)
In-Reply-To: <20200408094526.GC24663@zn.tnic>
On Wed, Apr 08, 2020 at 11:45:26AM +0200, Borislav Petkov wrote:
> Hi guys,
>
> so I've come across this recently where the microcode loader
> has a trivial helper get_builtin_firmware() which scans through
> the builtin firmware to find microcode in there. Looking at
> fw_get_builtin_firmware(), that one does practically the same so how
> about I export it and have the microcode loader use it instead of
> homegrowing the same thing?
>
> IOW, something like this below?
>
> If you agree with the approach, I'll split it properly into patches,
> etc, of course.
Looks sane to me, thanks!
greg k-h
next prev parent reply other threads:[~2020-04-08 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 9:45 Export fw_get_builtin_firmware()? Borislav Petkov
2020-04-08 10:20 ` Greg Kroah-Hartman [this message]
2020-04-08 12:05 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408102003.GA1070237@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).