From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DE9C2D0F4 for ; Wed, 8 Apr 2020 19:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA5812072F for ; Wed, 8 Apr 2020 19:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729929AbgDHTQs (ORCPT ); Wed, 8 Apr 2020 15:16:48 -0400 Received: from verein.lst.de ([213.95.11.211]:43787 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728209AbgDHTQr (ORCPT ); Wed, 8 Apr 2020 15:16:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B967C68C4E; Wed, 8 Apr 2020 21:16:44 +0200 (CEST) Date: Wed, 8 Apr 2020 21:16:44 +0200 From: Christoph Hellwig To: Grygorii Strashko Cc: Christoph Hellwig , Marek Szyprowski , Robin Murphy , iommu@lists.linux-foundation.org, Sekhar Nori , linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma-debug: fix displaying of dma allocation type Message-ID: <20200408191644.GA12239@lst.de> References: <20200408184804.30522-1-grygorii.strashko@ti.com> <20200408184958.GA9945@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2020 at 10:13:55PM +0300, Grygorii Strashko wrote: >>> -static const char *type2name[5] = { "single", "page", >>> +static const char *type2name[5] = { "single", >>> "scather-gather", "coherent", >>> "resource" }; >> >> To make sure this doesn't happen anymore, can you switch to >> named initializers? >> > > Just to clarify. > Do you mean > [dma_debug_coherent] = "coherent", > ? Yes.