linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: vadym.kochan@plvision.eu
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org,
	challa@noironetworks.com, linux-kernel@vger.kernel.org,
	taras.chornyi@plvision.eu
Subject: Re: [PATCH net v3] net: ipv4: devinet: Fix crash when add/del multicast IP with autojoin
Date: Thu, 09 Apr 2020 10:28:14 -0700 (PDT)	[thread overview]
Message-ID: <20200409.102814.2035520677628509572.davem@davemloft.net> (raw)
In-Reply-To: <20200409172524.26385-1-vadym.kochan@plvision.eu>

From: Vadym Kochan <vadym.kochan@plvision.eu>
Date: Thu,  9 Apr 2020 20:25:24 +0300

> From: Taras Chornyi <taras.chornyi@plvision.eu>
> 
> When CONFIG_IP_MULTICAST is not set and multicast ip is added to the device
> with autojoin flag or when multicast ip is deleted kernel will crash.
> 
> steps to reproduce:
> 
> ip addr add 224.0.0.0/32 dev eth0
> ip addr del 224.0.0.0/32 dev eth0
> 
> or
> 
> ip addr add 224.0.0.0/32 dev eth0 autojoin
> 
> Unable to handle kernel NULL pointer dereference at virtual address 0000000000000088
>  pc : _raw_write_lock_irqsave+0x1e0/0x2ac
>  lr : lock_sock_nested+0x1c/0x60
>  Call trace:
>   _raw_write_lock_irqsave+0x1e0/0x2ac
>   lock_sock_nested+0x1c/0x60
>   ip_mc_config.isra.28+0x50/0xe0
 ...
> Fixes: 93a714d6b53d ("multicast: Extend ip address command to enable multicast group join/leave on")
> Signed-off-by: Taras Chornyi <taras.chornyi@plvision.eu>
> Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu>

Applied and queued up for -stable, thanks.

      reply	other threads:[~2020-04-09 17:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 17:25 [PATCH net v3] net: ipv4: devinet: Fix crash when add/del multicast IP with autojoin Vadym Kochan
2020-04-09 17:28 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200409.102814.2035520677628509572.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=challa@noironetworks.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=taras.chornyi@plvision.eu \
    --cc=vadym.kochan@plvision.eu \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).