From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ADCDC38A2A for ; Thu, 9 Apr 2020 08:54:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FE0021D82 for ; Thu, 9 Apr 2020 08:35:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbgDIIfQ (ORCPT ); Thu, 9 Apr 2020 04:35:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:40789 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbgDIIfQ (ORCPT ); Thu, 9 Apr 2020 04:35:16 -0400 Received: from ip5f5bd698.dynamic.kabel-deutschland.de ([95.91.214.152] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jMSci-0007C4-7g; Thu, 09 Apr 2020 08:33:20 +0000 Date: Thu, 9 Apr 2020 10:33:19 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Jens Axboe , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-api@vger.kernel.org, Jonathan Corbet , Serge Hallyn , "Rafael J. Wysocki" , Tejun Heo , "David S. Miller" , Saravana Kannan , Jan Kara , David Howells , Seth Forshee , David Rheinsberg , Tom Gundersen , Christian Kellner , Dmitry Vyukov , =?utf-8?B?U3TDqXBoYW5l?= Graber , linux-doc@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 2/8] loopfs: implement loopfs Message-ID: <20200409083319.nlemf6d7g33hxhiy@wittgenstein> References: <20200408152151.5780-1-christian.brauner@ubuntu.com> <20200408152151.5780-3-christian.brauner@ubuntu.com> <20200409075320.GA26234@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200409075320.GA26234@infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2020 at 12:53:20AM -0700, Christoph Hellwig wrote: > Almost 600 lines of code for a little bit of fine grained control > is the wrong tradeoff. Please find a cheaper way to do this. I think that's a slight misrepresentation of the patchset. Of course, I get reservations against adding new code but none of this code will exist at all if the config option is not set; and the config option is not selected by default. I don't want people to have to use something they don't care about of course. The patchset itself unblocks a range of use-cases we had issues with for quite a while and the standalone, tiny filesystem approach has served us well already, so this is not something new. It's not just gaining fine-grained control, it's a whole set of new uses and we don't just do it for the fun of doing it but because we do have actual users of this. Christian